Looks good.
Lukasz
On Thu, Jan 27, 2011 at 5:58 PM, Brian Bockelman <[log in to unmask]> wrote:
> Hi Lukasz,
>
> How about this patch?
>
> Brian
>
> Index: net/netx/src/TXNetFile.cxx
> ===================================================================
> --- net/netx/src/TXNetFile.cxx (revision 37899)
> +++ net/netx/src/TXNetFile.cxx (working copy)
> @@ -1387,7 +1387,7 @@
> }
>
> if (newbsz > 0)
> - fClient->SetCacheParameters(newbsz, 0, XrdClientReadCache::kRmBlk_FIFO);
> + fClient->SetCacheParameters(newbsz, -1, XrdClientReadCache::kRmBlk_FIFO);
> }
>
> //_____________________________________________________________________________
>
>
> On Jan 27, 2011, at 11:56 AM, Lukasz Janyst wrote:
>
>> Hi Brian,
>>
>> On Thu, Jan 27, 2011 at 5:37 PM, Brian Bockelman <[log in to unmask]> wrote:
>>> So, if we use TTreeCache on any tree on the file, read-ahead is turned off?
>>
>> To be precise, async reads from ROOT force the cache
>> synchronization with xroot and this may overwrite cache settings of
>> the underlying xroot client (including the readahead size).
>>
>>> I would say this is simply wrong
>>
>> Well, I agree. I will have a closer look and try to fix it.
>>
>> Lukasz
>
>
|