Hi Wilko,
Being htonll and ntohll function they are never defined as macros
and that line
evaluates in the wrong way on other solaris implementations.
So, we cannot go back to that but we need to add something to fix
Solaris 5.10 on x86.
Which SLAC machine is this (I mean the hostname ...)? I will have a
look tomorrow ...
Cheers, Gerri
On 03/22/2011 07:01 PM, Wilko Kroeger wrote:
>
> Hello Gerri
>
> I tried to build the latest commit on Solaris 5.10 on x86 at slac but
> it fails with:
>
> Compiling XrdOucPup.cc
> "XrdOucPup.cc", line 180: Error: The function "htonll" must have a
> prototype.
> "XrdOucPup.cc", line 310: Error: The function "ntohll" must have a
> prototype.
> 2 Error(s) detected.
> gmake[4]: *** [../../obj/sunx86_510_dbg/XrdOucPup.o] Error 2
>
>
> If I restore XrdSysPlatform.hh to v3.0.2 it compiles fine. The
> difference is:
>
> % git diff v3.0.2 ./XrdSys/XrdSysPlatform.hh
> ...
> -#if !defined(__sun) || (defined(__sun) && (!defined(htonll) ||
> !defined(ntohll)))
> +#if !defined(__sun) || (defined(__sun) && (!defined(_LP64)))
> ...
>
> I think what is in version v3.0.2 was added because we had an issue
> with htonll/ntohll compiling on Solaris whereas it worked on OpenSolaris.
>
>
> Cheers,
> Wilko
|