LISTSERV mailing list manager LISTSERV 16.5

Help for HPS-SOFTWARE Archives


HPS-SOFTWARE Archives

HPS-SOFTWARE Archives


HPS-SOFTWARE@LISTSERV.SLAC.STANFORD.EDU


View:

Message:

[

First

|

Previous

|

Next

|

Last

]

By Topic:

[

First

|

Previous

|

Next

|

Last

]

By Author:

[

First

|

Previous

|

Next

|

Last

]

Font:

Proportional Font

LISTSERV Archives

LISTSERV Archives

HPS-SOFTWARE Home

HPS-SOFTWARE Home

HPS-SOFTWARE  May 2014

HPS-SOFTWARE May 2014

Subject:

Re: AIDAFrame

From:

"McCormick, Jeremy I." <[log in to unmask]>

Reply-To:

Software for the Heavy Photon Search Experiment <[log in to unmask]>

Date:

Tue, 20 May 2014 11:06:02 -0700

Content-Type:

text/plain

Parts/Attachments:

Parts/Attachments

text/plain (110 lines)

Hi,

The class has been marked as deprecated for almost 2 years, which means that a) it should not have been used in new code since then (though it was because people tend to simply copy and paste entire Drivers without understanding all their contents) and b) it will be removed at some point.

So I guess the "gradual approach" here is that I'm giving a grace period (flexible amount of time) to remove this yourself from your own code, after which I'll do it myself.  Though if there is a truly compelling reason this class needs to be kept around we could perhaps postpone this.

1) No, the problem has to do with the fact that any plots which are put into an external frame are not then handled and managed properly by the installed AnalysisFactory backend class.  It isn't a catastrophic problem though.  The GUI just ends up doing weird things sometimes, like not displaying plots in the place you think it should.

2) The class was originally intended to help organize plots that were displayed as Drivers were run that created them.  JAS3 does a much better job of this.  Other uses such as ad hoc manipulation of the underlying panels in the plotting GUI should be handled as I have previously indicated (by custom factory class).

3) I really want to completely remove it.  What is the worry here?  If there are Drivers that depend on it in some crucial way (not clear to me actually), then please let me know about them.

I believe there is some code in some of the ECAL monitoring that was written using this class, maybe something about clicking the event display to change plots.  But I'm not sure AIDAFrame is the proper way to do this if it is in fact being used there. 

--Jeremy

-----Original Message-----
From: Stuart Fegan [mailto:[log in to unmask]] 
Sent: Tuesday, May 20, 2014 1:41 AM
To: McCormick, Jeremy I.
Cc: Andrea Celentano; hps-software
Subject: Re: AIDAFrame

Jeremy,

I'd be interested in hearing a bit more detail on this, hopefully at a future software meeting.  Unfortunately my attendance for the next two weeks is uncertain, so in the meantime let me ask a couple of questions here (cc'd to software list);

1) What are the potential problems caused by the use of AIDAFrame in the monitoring app, and how serious are those problems?  i.e. will it cause occasional crashes, or render the application unusable during the run?  
Or worse, will it effect the information displayed in the plots to the point where those plots are no longer displaying real information?

2) I'm not sure running in batch mode with JAS3 is a viable replacement for every plot, and I'm not clear how big a task it is to implement a "proper" solution.  Would you be in a position to describe an example of how to do this?

3) Is a more gradual approach to removing AIDAFrame possible? Can it be done driver-by-driver, without breaking all the copy-and-paste style relatives?  If we don't have the (time and people) resources to remove AIDAFrame from everything, is there a way of leaving some of the drivers that use this?

Thanks in advance for any insight you can provide.

Cheers,
Stuart

On 19/05/14 22:27, McCormick, Jeremy I. wrote:
> It only really works fine by happenstance.  All lines of code that use AIDAFrame should be commented out.  Once this is done we need a more proper solution for organizing plots interactively, but that's the first step...
>
> -----Original Message-----
> From: Andrea Celentano [mailto:[log in to unmask]]
> Sent: Monday, May 19, 2014 2:21 PM
> To: McCormick, Jeremy I.; hps-software
> Subject: Re: AIDAFrame
>
> Uhm,
> can you be more specific? I wrote the drivers for the Ecal monitoring, and they all work fine in the monitoring app.
> I started from what was done for the test run.
>
> I have no idea of what I'd need to do, but if you point me to a part of the code in any of the drivers I need to modify, explaining what to do, I can try.
>
> Andrea
> On 05/19/2014 10:58 PM, McCormick, Jeremy I. wrote:
>> Hi,
>>
>> I was looking at fixing this today:
>>
>> https://jira.slac.stanford.edu/browse/HPSJAVA-48
>>
>> "Remove usage of AIDAFrame"
>>
>> Unfortunately, due to copy-and-paste style coding this class is now being used all over the place now, in approximately 20 or so Drivers.
>>
>> The problem with AIDAFrame is that it interferes with the "normal" usage of AIDA and also, more seriously, the embedding of plots in the monitoring app.
>>
>> So I need everyone to remove it from their code, which includes Drivers written by Omar, Pelle, Sho, and Andrea.
>>
>> In about a week, I'll start doing it myself for the remaining Drivers, so that I can fix this bug and close out the item.  It will probably break your code if I do it, so you probably want to do it yourself.
>>
>> If we decide that we need AIDA plots to be organized better as they are shown interactively, there is a way to do it by overriding certain classes in the AIDA backend.  Personally, I find it sufficient to run a job in batch mode and then look at the plots in JAS3.
>>
>> You can also just run your code within JAS3 if you really want a full hierarchical view of the in-memory AIDA objects as they are created and filled.
>>
>> Thanks.
>>
>> --Jeremy
>>
>> #####################################################################
>> #
>> ##
>> Use REPLY-ALL to reply to list
>>
>> To unsubscribe from the HPS-SOFTWARE list, click the following link:
>> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1
> ######################################################################
> ##
> Use REPLY-ALL to reply to list
>
> To unsubscribe from the HPS-SOFTWARE list, click the following link:
> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1


--
Dr Stuart Fegan
Postdoctoral Researcher
INFN-Genova
Via Dodecaneso, 33 - 16146, Genova
Italia

E-mail: [log in to unmask]

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the HPS-SOFTWARE list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1

Top of Message | Previous Page | Permalink

Advanced Options


Options

Log In

Log In

Get Password

Get Password


Search Archives

Search Archives


Subscribe or Unsubscribe

Subscribe or Unsubscribe


Archives

June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
December 2022
November 2022
October 2022
September 2022
August 2022
June 2022
April 2022
March 2022
February 2022
January 2022
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011

ATOM RSS1 RSS2



LISTSERV.SLAC.STANFORD.EDU

Secured by F-Secure Anti-Virus CataList Email List Search Powered by the LISTSERV Email List Manager

Privacy Notice, Security Notice and Terms of Use