Hi,

The class has been marked as deprecated for almost 2 years, which means that a) it should not have been used in new code since then (though it was because people tend to simply copy and paste entire Drivers without understanding all their contents) and b) it will be removed at some point.

So I guess the "gradual approach" here is that I'm giving a grace period (flexible amount of time) to remove this yourself from your own code, after which I'll do it myself.  Though if there is a truly compelling reason this class needs to be kept around we could perhaps postpone this.

1) No, the problem has to do with the fact that any plots which are put into an external frame are not then handled and managed properly by the installed AnalysisFactory backend class.  It isn't a catastrophic problem though.  The GUI just ends up doing weird things sometimes, like not displaying plots in the place you think it should.

2) The class was originally intended to help organize plots that were displayed as Drivers were run that created them.  JAS3 does a much better job of this.  Other uses such as ad hoc manipulation of the underlying panels in the plotting GUI should be handled as I have previously indicated (by custom factory class).

3) I really want to completely remove it.  What is the worry here?  If there are Drivers that depend on it in some crucial way (not clear to me actually), then please let me know about them.

I believe there is some code in some of the ECAL monitoring that was written using this class, maybe something about clicking the event display to change plots.  But I'm not sure AIDAFrame is the proper way to do this if it is in fact being used there. 

--Jeremy

-----Original Message-----
From: Stuart Fegan [mailto:[log in to unmask]] 
Sent: Tuesday, May 20, 2014 1:41 AM
To: McCormick, Jeremy I.
Cc: Andrea Celentano; hps-software
Subject: Re: AIDAFrame

Jeremy,

I'd be interested in hearing a bit more detail on this, hopefully at a future software meeting.  Unfortunately my attendance for the next two weeks is uncertain, so in the meantime let me ask a couple of questions here (cc'd to software list);

1) What are the potential problems caused by the use of AIDAFrame in the monitoring app, and how serious are those problems?  i.e. will it cause occasional crashes, or render the application unusable during the run?  
Or worse, will it effect the information displayed in the plots to the point where those plots are no longer displaying real information?

2) I'm not sure running in batch mode with JAS3 is a viable replacement for every plot, and I'm not clear how big a task it is to implement a "proper" solution.  Would you be in a position to describe an example of how to do this?

3) Is a more gradual approach to removing AIDAFrame possible? Can it be done driver-by-driver, without breaking all the copy-and-paste style relatives?  If we don't have the (time and people) resources to remove AIDAFrame from everything, is there a way of leaving some of the drivers that use this?

Thanks in advance for any insight you can provide.

Cheers,
Stuart

On 19/05/14 22:27, McCormick, Jeremy I. wrote:
> It only really works fine by happenstance.  All lines of code that use AIDAFrame should be commented out.  Once this is done we need a more proper solution for organizing plots interactively, but that's the first step...
>
> -----Original Message-----
> From: Andrea Celentano [mailto:[log in to unmask]]
> Sent: Monday, May 19, 2014 2:21 PM
> To: McCormick, Jeremy I.; hps-software
> Subject: Re: AIDAFrame
>
> Uhm,
> can you be more specific? I wrote the drivers for the Ecal monitoring, and they all work fine in the monitoring app.
> I started from what was done for the test run.
>
> I have no idea of what I'd need to do, but if you point me to a part of the code in any of the drivers I need to modify, explaining what to do, I can try.
>
> Andrea
> On 05/19/2014 10:58 PM, McCormick, Jeremy I. wrote:
>> Hi,
>>
>> I was looking at fixing this today:
>>
>> https://jira.slac.stanford.edu/browse/HPSJAVA-48
>>
>> "Remove usage of AIDAFrame"
>>
>> Unfortunately, due to copy-and-paste style coding this class is now being used all over the place now, in approximately 20 or so Drivers.
>>
>> The problem with AIDAFrame is that it interferes with the "normal" usage of AIDA and also, more seriously, the embedding of plots in the monitoring app.
>>
>> So I need everyone to remove it from their code, which includes Drivers written by Omar, Pelle, Sho, and Andrea.
>>
>> In about a week, I'll start doing it myself for the remaining Drivers, so that I can fix this bug and close out the item.  It will probably break your code if I do it, so you probably want to do it yourself.
>>
>> If we decide that we need AIDA plots to be organized better as they are shown interactively, there is a way to do it by overriding certain classes in the AIDA backend.  Personally, I find it sufficient to run a job in batch mode and then look at the plots in JAS3.
>>
>> You can also just run your code within JAS3 if you really want a full hierarchical view of the in-memory AIDA objects as they are created and filled.
>>
>> Thanks.
>>
>> --Jeremy
>>
>> #####################################################################
>> #
>> ##
>> Use REPLY-ALL to reply to list
>>
>> To unsubscribe from the HPS-SOFTWARE list, click the following link:
>> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1
> ######################################################################
> ##
> Use REPLY-ALL to reply to list
>
> To unsubscribe from the HPS-SOFTWARE list, click the following link:
> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1


--
Dr Stuart Fegan
Postdoctoral Researcher
INFN-Genova
Via Dodecaneso, 33 - 16146, Genova
Italia

E-mail: [log in to unmask]

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the HPS-SOFTWARE list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1