Jacek,

> I am trying to turn Bill's code currently in qserv repo
> in u/bchick/log branch into a "log" package.

	That isn't the final version.  The final version is in
contrib/log.git.

> 1) I think the path include/lsst/devenv/log should
>    really be include/lsst/log, so I changed that

	That looks like the right thing to do.

> 2) I am not sure why we would want to depend on utils,
>    so I made this change in ups.log.cfg:
> 
> -    "required": ["utils", ],
> +    "required": [],

	OK.  You also need to fix the name of the provided header file,
unless you want to create an lsst/log.h.

> 3) I also fixed the ups.log.table:
>    a) I don't think we want to depend on pex_exceptions

	In the long run, it will be very awkward for the rest of the
LSST Stack if this package does not use pex_exceptions (or whatever it
gets renamed).  I think you should reconsider this position.

>    b) I think we do depend on python and sconsUtils

	Depending on python is sort of optional, but OK.

	sconsUtils is really only a build dependency, but also OK.

>    c) I aligned it with the latest format as we use in qserv
>    So it now looks like:
> 
> setupRequired(boost)
> setupRequired(python)
> setupRequired(sconsUtils)
> 
> envPrepend(PYTHONPATH, ${PRODUCT_DIR}/lib/python)
> envPrepend(LD_LIBRARY_PATH, ${PRODUCT_DIR}/lib)
> envPrepend(PATH, ${PRODUCT_DIR}/bin)

	Removing the version numbers is good.

> I thought the sconsUtils does all the magic with g++ flags,
> but apparently not:
> 
> 
> scons
> scons: Reading SConscript files ...
> Checking who built the CC compiler...(cached) gcc
> Checking for C++ header file tr1/unordered_map... (cached) yes
> Setting up environment to build package 'log'.
> Checking whether int64_t is long ... (cached) yes
> scons: done reading SConscript files.
> scons: Building targets ...
> g++ -o src/logInterface.os -c -g -DLSST_HAVE_TR1=1
> -DLSST_LITTLE_ENDIAN=1 -O0 -Wall -Wno-unknown-pragmas -fPIC
> -Iinclude
> -I/usr/local/home/becla/qservDev/Linux64/boost/1.55.0.1+1/include -I/usr/local/home/becla/qservDev/Linux64/anaconda/1.8.0/include/python2.7
> src/logInterface.cc
> src/logInterface.cc:32:21: error: log/Log.h: No such file or directory
> src/logInterface.cc:33:30: error: log/logInterface.h: No such file
> or directory

	This is because the source file doesn't say "lsst/log" as it
should.

-- 
Kian-Tat Lim, LSST Data Management, [log in to unmask]

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the QSERV-L list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=QSERV-L&A=1