Daniel
I am ok with letting the code into master as long as it passes
our current set of unit tests and the integration tests. We
should open new tickets that cover issues that you found, and
keep them close to the top of the backlog (or in Aug sprint
if possible). Can yo do that?
I'll test your fix today.
thanks,
Jacek
On 07/24/2014 04:36 PM, Wang, Daniel Liwei wrote:
> Hi Jacek,
>
> I think I've fixed the problem with not passing a db context for user
> queries. The fix was pretty simple.
>
> In testing, I've found some things that bother me, with respect to error
> reporting and perhaps robustness. I don't know if you want to delay this
> ticket though. It might be better to get this merged and have a new
> ticket for the error management.
>
> Let me know if it fails any other cases--I agree we need to get those
> treated before merging.
>
> Code updated at the tip of u/danielw/kirkwood . I'll do a squash into a
> few meaningful commits and put it on a ticket branch once you think it's
> more or less functional.
>
> Thanks,
> -Daniel
>
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the QSERV-L list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=QSERV-L&A=1
|