LISTSERV mailing list manager LISTSERV 16.5

Help for XROOTD-DEV Archives


XROOTD-DEV Archives

XROOTD-DEV Archives


XROOTD-DEV@LISTSERV.SLAC.STANFORD.EDU


View:

Message:

[

First

|

Previous

|

Next

|

Last

]

By Topic:

[

First

|

Previous

|

Next

|

Last

]

By Author:

[

First

|

Previous

|

Next

|

Last

]

Font:

Proportional Font

LISTSERV Archives

LISTSERV Archives

XROOTD-DEV Home

XROOTD-DEV Home

XROOTD-DEV  November 2014

XROOTD-DEV November 2014

Subject:

[xrootd/xrootd] e3ee50: Make sure the wakePend flag does not incur undefin...

From:

Andrew Hanushevsky <[log in to unmask]>

Reply-To:

Andrew Hanushevsky <[log in to unmask]>

Date:

Mon, 24 Nov 2014 15:01:20 -0800

Content-Type:

multipart/mixed

Parts/Attachments:

Parts/Attachments

text/plain (89 lines)

  Branch: refs/heads/master
  Home:   https://github.com/xrootd/xrootd
  Commit: e3ee50672a455d3e620bc67b593cbef62b059a72
      https://github.com/xrootd/xrootd/commit/e3ee50672a455d3e620bc67b593cbef62b059a72
  Author: Brian Bockelman <[log in to unmask]>
  Date:   2014-11-17 (Mon, 17 Nov 2014)

  Changed paths:
    M src/XrdSys/XrdSysIOEvents.cc
    M src/XrdSys/XrdSysIOEvents.hh
    M src/XrdSys/XrdSysIOEventsPollE.icc

  Log Message:
  -----------
  Make sure the wakePend flag does not incur undefined behavior.

The wakePend flag currently has undefined behavior as multiple threads
read and write to it without a consistent locking mechanism.  This
switches writes and reads to use C++11's release-consume ordering
when available.  Without this patch, we have undefined behavior - which
is illegal with C++11.

The release-consume ordering is sufficient to guarantee atomicity
and the ordering of wakePend writes; other than that, it's a very
weak memory model.  In practice, this is a guarantee already provided
by all interesting architectures (it only generates different assembler
on DEC Alpha).

Fixes #167


  Commit: 1435552729b0e0bf6373aca5efd948d628501ecc
      https://github.com/xrootd/xrootd/commit/1435552729b0e0bf6373aca5efd948d628501ecc
  Author: Brian Bockelman <[log in to unmask]>
  Date:   2014-11-20 (Thu, 20 Nov 2014)

  Changed paths:
    M src/XrdSys/XrdSysAtomics.hh
    M src/XrdSys/XrdSysIOEvents.cc
    M src/XrdSys/XrdSysIOEvents.hh
    M src/XrdSys/XrdSysIOEventsPollE.icc

  Log Message:
  -----------
  Replace ifdef's with CPP_ATOMIC_* macros.


  Commit: dac6ee52d12ae5d49c4317618890238e70f17823
      https://github.com/xrootd/xrootd/commit/dac6ee52d12ae5d49c4317618890238e70f17823
  Author: Brian Bockelman <[log in to unmask]>
  Date:   2014-11-21 (Fri, 21 Nov 2014)

  Changed paths:
    M src/XrdSys/XrdSysAtomics.hh
    M src/XrdSys/XrdSysIOEvents.cc

  Log Message:
  -----------
  Re-introduce the toMutex lock and explain why this is necessary.

NOTE: also fixed a debug line accidentally committed to XrdSysAtomics.hh


  Commit: ab9e2a3d72f4f0fb0afef8272996323c881844e7
      https://github.com/xrootd/xrootd/commit/ab9e2a3d72f4f0fb0afef8272996323c881844e7
  Author: Andrew Hanushevsky <[log in to unmask]>
  Date:   2014-11-24 (Mon, 24 Nov 2014)

  Changed paths:
    M src/XrdSys/XrdSysAtomics.hh
    M src/XrdSys/XrdSysIOEvents.cc
    M src/XrdSys/XrdSysIOEvents.hh
    M src/XrdSys/XrdSysIOEventsPollE.icc

  Log Message:
  -----------
  Merge pull request #170 from bbockelm/fix-wakepend-loads

Make sure the wakePend flag does not incur undefined behavior.


Compare: https://github.com/xrootd/xrootd/compare/16b3682883df...ab9e2a3d72f4

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1

Top of Message | Previous Page | Permalink

Advanced Options


Options

Log In

Log In

Get Password

Get Password


Search Archives

Search Archives


Subscribe or Unsubscribe

Subscribe or Unsubscribe


Archives

August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
December 2010
November 2010
October 2010
September 2010

ATOM RSS1 RSS2



LISTSERV.SLAC.STANFORD.EDU

Secured by F-Secure Anti-Virus CataList Email List Search Powered by the LISTSERV Email List Manager

Privacy Notice, Security Notice and Terms of Use