LISTSERV mailing list manager LISTSERV 16.5

Help for HPS-SOFTWARE Archives


HPS-SOFTWARE Archives

HPS-SOFTWARE Archives


HPS-SOFTWARE@LISTSERV.SLAC.STANFORD.EDU


View:

Message:

[

First

|

Previous

|

Next

|

Last

]

By Topic:

[

First

|

Previous

|

Next

|

Last

]

By Author:

[

First

|

Previous

|

Next

|

Last

]

Font:

Proportional Font

LISTSERV Archives

LISTSERV Archives

HPS-SOFTWARE Home

HPS-SOFTWARE Home

HPS-SOFTWARE  December 2014

HPS-SOFTWARE December 2014

Subject:

Re: EVIO to LCIO: Raw Hit Energy

From:

Sho Uemura <[log in to unmask]>

Reply-To:

Software for the Heavy Photon Search Experiment <[log in to unmask]>

Date:

Mon, 15 Dec 2014 21:47:01 -0800

Content-Type:

TEXT/PLAIN

Parts/Attachments:

Parts/Attachments

TEXT/PLAIN (267 lines)

Two things.

1. The sampling fraction in LCSim is set to 1, so "raw energy" and 
"corrected energy" are always the same for our hits. This is regardless of 
the fact that the sampling fraction of the physical detector is 0.89; 
unless that number gets plugged in to the LCSim sampling fraction 
calculator, it has no bearing on this discussion.

2. Yes, it is trivial to calculate raw energy from corrected energy, 
particularly given point 1. But this is not done automatically; 
BaseCalorimeterHit.getRawEnergy() crashes if the raw energy is unset. 
(Corrected energy is, on the other hand, automatically calculated. I think 
you could argue that this is the way it should be, but I don't really 
know.) So you could catch the exception and do the calculation yourself, 
but that's really a shitty hack.

On Tue, 16 Dec 2014, McCormick, Jeremy I. wrote:

> Hi,
>
> Perhaps I?m not completely understanding all the details here in this thread, but isn?t the raw energy easily recoverable if you have the corrected energy and know the sampling fraction that was applied to get it?
>
> correctedEnergy = rawEnergy / samplingFraction
>
> where sampling Fraction is the 0.89 number (from Holly?s email).
>
> So can?t you just get the raw energy back with?.
>
> rawEnergy = correctedEnergy * samplingFraction
>
> It seems like if you have one you can get the other.
>
> If there are spots in BaseCluster that use raw energy and this is actually needed then it seems like this calculation could be performed.
>
> I had thought there was behavior in BaseCalorimeterHit to do this (calculate raw from correct energy) so that the code would not crash, but I need to look over it again?
>
> Can someone send the exact error that is happening which is causing problems here?  (Kyle?)
>
> ?Jeremy
>
> On Dec 15, 2014, at 2:50 PM, Greg Kalicy <[log in to unmask]<mailto:[log in to unmask]>> wrote:
>
> Hi,
>
> Why can not we change the labelling until corrections work again? It will be very confusing probably even for us after 2 weeks - which were corrected and which not?
>
> Cheers,
>
> Greg
>
> On 15 Dec 2014, at 17:44, Holly Vance <[log in to unmask]<mailto:[log in to unmask]>> wrote:
>
> Hi,
>
> I think the simplest fix in the clustering is to set the raw energy and the corrected energy to be the same until the energy corrections are done-at which point, we can overwrite the corrected energy. This should work with all of the previous codes of others (since raw energy is not filled by anything else) and allow us to store the information from both in the offline clustering.
>
> The only part I don't like about this is the labeling. If something says "corrected energy" then I feel it should really be the corrected energy-otherwise it can get confusing. Currently, the corrected energy is uncorrected since the event display is reading this. Not a big deal as long as everyone knows when the corrections occur in the code.
>
> On Mon, Dec 15, 2014 at 5:35 PM, Graf, Norman A. <[log in to unmask]<mailto:[log in to unmask]>> wrote:
>
> Hello Stepan,
>
> Agreed.
>
> Norman
>
> ________________________________
> From: Stepan Stepanyan <[log in to unmask]<mailto:[log in to unmask]>>
> Sent: Monday, December 15, 2014 2:26 PM
> To: Graf, Norman A.; 'Holly Vance'
>
> Cc: Uemura, Sho; Kyle McCarty; hps-software
> Subject: Re: EVIO to LCIO: Raw Hit Energy
>
> Norman and Holly,
>
> I may not fully understand problem but want to point
> that we need to keep both reconstructed cluster energy
> and corrected final energy of particle. This is how our
> clustering worked and it was absolutely useful.
>
> Thanks, Stepan
>
> On 12/15/14, 4:37 PM, Graf, Norman A. wrote:
> Hello Holly,
> Thanks for that follow-up. It?s clear we should discuss this some more.
> Norman
>
> From: [log in to unmask]<mailto:[log in to unmask]> [mailto:[log in to unmask]] On Behalf Of Holly Vance
> Sent: Monday, December 15, 2014 1:27 PM
> To: Graf, Norman A.
> Cc: Uemura, Sho; Kyle McCarty; hps-software
> Subject: Re: EVIO to LCIO: Raw Hit Energy
>
> Hi Norman,
>
> I can fix change this in the offline clustering code. I would like to remind you that sampling fractions are actually on the order of about 0.89 until corrected. I strongly feel that we need to preserve both of these energies because I would like to compare what we really find with how I calculated the energy corrections in simulation. Using the setEnergy() method later in reconstruction will overwrite the original energy.
>
> At the moment, I've removed energy corrections from the clustering since it's necessary that getEnergy() returns the raw (uncorrected) energy for use in the event display in the counting house. All corrections will be done later in reconstruction with cluster track matching, but I don't think it's good to overwrite the raw/uncorrected energy yet.
>
>
>
> On Mon, Dec 15, 2014 at 4:13 PM, Graf, Norman A. <[log in to unmask]<mailto:[log in to unmask]>> wrote:
> Hello Holly et al.,
> Here?s my proposal:
> We change the call to getRawEnergy() in HPSEcalClusterIC.recalculateForParticleID()
> to getEnergy(). Our sampling fractions are 1.0 so the returned energy is the same in either
> case. This method is not called at present, so it does not change any behavior.
> We then eliminate the references to raw energy in org.lcsim.event.baseBaseCluster.
> I can do this now, or we can discuss this further in detail.
> Norman
>
> From: Holly Vance [mailto:[log in to unmask]<mailto:[log in to unmask]>]
> Sent: Monday, December 15, 2014 1:06 PM
> To: Graf, Norman A.
> Cc: Uemura, Sho; Kyle McCarty; hps-software
>
> Subject: Re: EVIO to LCIO: Raw Hit Energy
>
> Hi all,
>
> The raw energy is calculated separately and then set because it includes considerations for hits shared between clusters (energy is distributed then). Also, the raw energy is used separately to calculate the corrected energy.
>
> It is a bit of a question of semantics, but there must be a distinction for the offline clustering since this is where the corrections happen.
>
> Let me know how we wish to proceed.
>
> On Mon, Dec 15, 2014 at 3:10 PM, Graf, Norman A. <[log in to unmask]<mailto:[log in to unmask]>> wrote:
> Hello All,
> This is complicated by the fact that HPSEcalClusterIC actually calls getRawEnergy() before
> calculating the cluster position and energy corrections. I am checking to understand
> whether this is just a semantic issue.
> Norman
>
> -----Original Message-----
> From: [log in to unmask]<mailto:[log in to unmask]> [mailto:[log in to unmask]<mailto:[log in to unmask]>] On Behalf Of Sho Uemura
> Sent: Monday, December 15, 2014 10:54 AM
> To: Kyle McCarty
> Cc: hps-software
> Subject: Re: EVIO to LCIO: Raw Hit Energy
>
> This is a known incompatibility between the LCSim builtin classes - a CalorimeterHit read from LCIO (SIOCalorimeterHit) has a corrected energy but no raw energy, and the LCSim base implementation of Cluster
> (BaseCluster) uses the hit raw energy. We've always tried to avoid this by using corrected energy when possible.
>
> The HPS subclasses of BaseCluster do not override that behavior; it's not "our fault" that the cluster code crashes. But either BaseCluster gets changed so it doesn't use raw energy, or we override the methods of BaseCluster that do.
>
> On Mon, 15 Dec 2014, Kyle McCarty wrote:
>
>> Hello hps-software,
>>
>> I am trying to write a version of the GTP clustering algorithm to run
>> over EVIO readout data and form clusters from the hits. This is useful
>> both to get cluster data that closely matches what the hardware is
>> actually seeing and also for trigger verification and diagnostic
>> drivers, since these will need to run the trigger over clusters that match the hardware.
>>
>> I am running into a problem with this because the readout hits do not
>> declare a raw energy and attempting to access it causes a RuntimeException.
>> Normally, we use corrected energy, which is available, but the addHit
>> method in HPSEcalCluster apparently calls getRawEnergy at some point
>> and thusly crashes the simulation.
>>
>> Is there a way to fix this so that the hits in the EVIO readout will
>> have this value when converted to LCIO? Alternatively, should we
>> change the HPSEcalCluster to use the corrected energy?
>>
>> Thanks,
>>
>> Kyle
>>
>> ######################################################################
>> ##
>> Use REPLY-ALL to reply to list
>>
>> To unsubscribe from the HPS-SOFTWARE list, click the following link:
>> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1
>>
>
> ########################################################################
> Use REPLY-ALL to reply to list
>
> To unsubscribe from the HPS-SOFTWARE list, click the following link:
> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1
>
> ########################################################################
> Use REPLY-ALL to reply to list
>
> To unsubscribe from the HPS-SOFTWARE list, click the following link:
> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1
>
>
> --
> BEGIN-ANTISPAM-VOTING-LINKS
> ------------------------------------------------------
>
> NOTE: This message was trained as non-spam.  If this is wrong,
> please correct the training as soon as possible.
> Teach CanIt if this mail (ID 01NrUbF6w) is spam:
> Spam:        about:blank
>
> Not spam:    about:blank
>
> Forget vote: about:blank
> ------------------------------------------------------
> END-ANTISPAM-VOTING-LINKS
> ________________________________
>
> Spam
> Not spam
> Forget previous vote
>
> ________________________________
>
> Use REPLY-ALL to reply to list
>
> To unsubscribe from the HPS-SOFTWARE list, click the following link:
> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1
>
> ________________________________
>
> Use REPLY-ALL to reply to list
>
> To unsubscribe from the HPS-SOFTWARE list, click the following link:
> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1
>
> ________________________________
> NOTE: This message was trained as non-spam. If this is wrong, please correct the training as soon as possible.
> Spam<https://www.spamtrap.odu.edu/canit/b.php?i=03NrWzOm6&m=257cb4a0adbc&t=20141215&c=s>
> Not spam<https://www.spamtrap.odu.edu/canit/b.php?i=03NrWzOm6&m=257cb4a0adbc&t=20141215&c=n>
> Forget previous vote<https://www.spamtrap.odu.edu/canit/b.php?i=03NrWzOm6&m=257cb4a0adbc&t=20141215&c=f>
>
> ________________________________
>
> Use REPLY-ALL to reply to list
>
> To unsubscribe from the HPS-SOFTWARE list, click the following link:
> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1
>
> ________________________________
>
> Use REPLY-ALL to reply to list
>
> To unsubscribe from the HPS-SOFTWARE list, click the following link:
> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1
>
>
> ________________________________
>
> Use REPLY-ALL to reply to list
>
> To unsubscribe from the HPS-SOFTWARE list, click the following link:
> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1
>
>
> ########################################################################
> Use REPLY-ALL to reply to list
>
> To unsubscribe from the HPS-SOFTWARE list, click the following link:
> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1
>

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the HPS-SOFTWARE list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1

Top of Message | Previous Page | Permalink

Advanced Options


Options

Log In

Log In

Get Password

Get Password


Search Archives

Search Archives


Subscribe or Unsubscribe

Subscribe or Unsubscribe


Archives

June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
December 2022
November 2022
October 2022
September 2022
August 2022
June 2022
April 2022
March 2022
February 2022
January 2022
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011

ATOM RSS1 RSS2



LISTSERV.SLAC.STANFORD.EDU

Secured by F-Secure Anti-Virus CataList Email List Search Powered by the LISTSERV Email List Manager

Privacy Notice, Security Notice and Terms of Use