LISTSERV mailing list manager LISTSERV 16.5

Help for HPS-SOFTWARE Archives


HPS-SOFTWARE Archives

HPS-SOFTWARE Archives


HPS-SOFTWARE@LISTSERV.SLAC.STANFORD.EDU


View:

Message:

[

First

|

Previous

|

Next

|

Last

]

By Topic:

[

First

|

Previous

|

Next

|

Last

]

By Author:

[

First

|

Previous

|

Next

|

Last

]

Font:

Proportional Font

LISTSERV Archives

LISTSERV Archives

HPS-SOFTWARE Home

HPS-SOFTWARE Home

HPS-SOFTWARE  December 2014

HPS-SOFTWARE December 2014

Subject:

code changes and cleanup

From:

"McCormick, Jeremy I." <[log in to unmask]>

Reply-To:

Software for the Heavy Photon Search Experiment <[log in to unmask]>

Date:

Wed, 17 Dec 2014 21:50:04 +0000

Content-Type:

text/plain

Parts/Attachments:

Parts/Attachments

text/plain (39 lines)

Hi,

I fixed/changed a bunch of things in the code yesterday, which everyone should know about...

1) HPSCalorimeterHit was removed.  This class was unneccessary, and all of its functionality that differed from BaseCalorimeterHit was integrated into the base class.  
All instances of using this class were replaced by BaseCalorimeterHit or the CalorimeterHit interface, instead.

2) I removed QuietBaseLCSimEvent which was a fork of BaseLCSimEvent which suppressed activation of the conditions system.  There is now a specialized constructor in BaseLCSimEvent for doing this.
(The old class was only used in one place so this doesn't affect very much code.)

3) I reworked some of the base classes and interfaces in LCSim related to hits so that it is much cleaner now how all their required data members get setup.  This is now done when the objects are created
instead of on the fly.  For instance, before it was trying to calculate corrected energy for SimCalorimeterHit objects in the "get" method but this is now done either just after the hit is read from an LCIO file
or in the base class constructor.  I think it is much cleaner now.  Similar fix up was done for setting the link to collection meta data, which associates a hit back to its collection information (for IDDecoder etc.).
All the initialization for these classes is being done when they are created instead of "on the fly" so this is much cleaner now.

4) I added a class to ecal-recon for conveniently creating CalorimeterHit objects depending on what information you would like to use.  It is called CalorimeterHitUtilities and has several methods for creating
BaseCalorimeterHit objects.  You should prefer using this interface in ECAL recon code if you need to create new hits from Driver code.  You may also use the BaseCalorimeterHit constructor, but you have to
supply all the required arguments to it.

5) I simplified and consolidated some of the various interfaces that are used for basic hit functionality within LCSim so there is now one primary interface which is extended by the official LCIO interfaces to get the 
basic functionality like retrieving a position.  It should be much clearer now how this works in LCSim.  I removed some mixin style interfaces that were not needed.

6) I made the way raw energy is handled for CalorimeterHit objects less error prone.  Basically now, the raw energy is going to always be set to zero for CalorimeterHit objects that are read back into a job via LCIO.  
Before we had some special double value for an unset raw energy in the implementation class, but this was confusing and unnecessary. 

There was a silly bug introduced with those fixes where the corrected energy was not being set for SimCalorimeterHit objects, and so anything related to MC ECAL was broken for a little while.  But I have fixed this.  
And I have confirmed that the IC clustering test produces reasonable results on mock data.

Now I'm going to move on to trying this on one of the more recent runs to see if anything is broken.  I did not hear from anyone (today!) that there were issues running on the raw data using EvioToLcio, but I'm going to
try and confirm this is all still working correctly....

--Jeremy

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the HPS-SOFTWARE list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1

Top of Message | Previous Page | Permalink

Advanced Options


Options

Log In

Log In

Get Password

Get Password


Search Archives

Search Archives


Subscribe or Unsubscribe

Subscribe or Unsubscribe


Archives

March 2024
February 2024
January 2024
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
December 2022
November 2022
October 2022
September 2022
August 2022
June 2022
April 2022
March 2022
February 2022
January 2022
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011

ATOM RSS1 RSS2



LISTSERV.SLAC.STANFORD.EDU

Secured by F-Secure Anti-Virus CataList Email List Search Powered by the LISTSERV Email List Manager

Privacy Notice, Security Notice and Terms of Use