LISTSERV mailing list manager LISTSERV 16.5

Help for HPS-SOFTWARE Archives


HPS-SOFTWARE Archives

HPS-SOFTWARE Archives


HPS-SOFTWARE@LISTSERV.SLAC.STANFORD.EDU


View:

Message:

[

First

|

Previous

|

Next

|

Last

]

By Topic:

[

First

|

Previous

|

Next

|

Last

]

By Author:

[

First

|

Previous

|

Next

|

Last

]

Font:

Proportional Font

LISTSERV Archives

LISTSERV Archives

HPS-SOFTWARE Home

HPS-SOFTWARE Home

HPS-SOFTWARE  January 2015

HPS-SOFTWARE January 2015

Subject:

Re: HPSRawCalorimeterHit

From:

Sho Uemura <[log in to unmask]>

Reply-To:

Software for the Heavy Photon Search Experiment <[log in to unmask]>

Date:

Fri, 9 Jan 2015 13:53:23 -0800

Content-Type:

TEXT/PLAIN

Parts/Attachments:

Parts/Attachments

TEXT/PLAIN (90 lines)

Fine, remove the class. It's not being used right now (the class was 
written when there wasn't a base implementation of RawCalorimeterHit, and 
I removed most usage after BaseRawCalorimeterHit was added), so it's good 
housekeeping. But I disagree with your reasons. If I were still using this 
class, I would argue to keep it in.


I agree that nobody should be using non-base classes to retrieve event 
information from LCIO. I don't see why that means you need to purge the 
codebase of non-base classes.

People who use non-base classes in their event.get() calls will get errors 
immediately when that driver is run from LCIO - no unpredictable behavior, 
and half a dozen people on the software list will recognize the error and 
know how to fix it. This is kind of the point of type safety.

Of course we need to discourage people from using non-base classes in code 
that might need to run from LCIO, but that's a problem you solve by 
documentation and user education - put a note in the class javadoc and/or 
put the class in a package specific to its use (make it clear the class is 
for readout simulation, not recon).

I particularly don't understand why ECal code is being held to such 
puritan standards when the SVT code is obviously never going to reach 
those standards. SVT code relies heavily on hit and track subclasses that 
cannot be recovered from LCIO. And people understand that, and we live 
with it.

On Fri, 9 Jan 2015, McCormick, Jeremy I. wrote:

> Okay....
>
> But the problem here is that any downstream analysis Driver in a separate job which tries to retrieve event information using this (public) class will fail.  Therefore, I believe it should be removed, in favor of using the base class from LCSim.
>
> And as far as I can tell there is only one reference in our entire code base that uses the window size information, which is just an analysis plot.
>
> So can the class simply be removed?
>
> I assume you have some other way of getting the window size or that it is simply a hard-coded parameter.  (Not sure, maybe you can clarify for me where this information comes from in the first place.)
>
> --Jeremy
>
> -----Original Message-----
> From: Sho Uemura [mailto:[log in to unmask]]
> Sent: Friday, January 09, 2015 12:05 PM
> To: McCormick, Jeremy I.
> Cc: hps-software
> Subject: Re: HPSRawCalorimeterHit
>
> The window size there is only used for MC studies, and it doesn't need to be persisted.
>
> On Fri, 9 Jan 2015, McCormick, Jeremy I. wrote:
>
>> Hi, Sho.
>>
>> In the ECAL code, is there another way we could keep track of the window size rather than extending an LCIO class?
>>
>> e.g.
>>
>> ecal-recon/src/main/java/org/hps/recon/ecal/HPSRawCalorimeterHit.java
>>
>> If this is something that is the same for all hits in the collection, then it would be possible to use a setting on the collection itself rather than each hit.
>>
>> Or is this value specific to each hit?
>>
>> As far as I can tell, the added method getWindowSize() is not even used anyplace in the reconstruction, so can it simply be removed?
>>
>> --Jeremy
>>
>> ######################################################################
>> ##
>> Use REPLY-ALL to reply to list
>>
>> To unsubscribe from the HPS-SOFTWARE list, click the following link:
>> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1
>>
>
> ########################################################################
> Use REPLY-ALL to reply to list
>
> To unsubscribe from the HPS-SOFTWARE list, click the following link:
> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1
>

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the HPS-SOFTWARE list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1

Top of Message | Previous Page | Permalink

Advanced Options


Options

Log In

Log In

Get Password

Get Password


Search Archives

Search Archives


Subscribe or Unsubscribe

Subscribe or Unsubscribe


Archives

February 2024
January 2024
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
December 2022
November 2022
October 2022
September 2022
August 2022
June 2022
April 2022
March 2022
February 2022
January 2022
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011

ATOM RSS1 RSS2



LISTSERV.SLAC.STANFORD.EDU

Secured by F-Secure Anti-Virus CataList Email List Search Powered by the LISTSERV Email List Manager

Privacy Notice, Security Notice and Terms of Use