LISTSERV mailing list manager LISTSERV 16.5

Help for HPS-SOFTWARE Archives


HPS-SOFTWARE Archives

HPS-SOFTWARE Archives


HPS-SOFTWARE@LISTSERV.SLAC.STANFORD.EDU


View:

Message:

[

First

|

Previous

|

Next

|

Last

]

By Topic:

[

First

|

Previous

|

Next

|

Last

]

By Author:

[

First

|

Previous

|

Next

|

Last

]

Font:

Monospaced Font

LISTSERV Archives

LISTSERV Archives

HPS-SOFTWARE Home

HPS-SOFTWARE Home

HPS-SOFTWARE  May 2015

HPS-SOFTWARE May 2015

Subject:

Re: collection issue

From:

"McCormick, Jeremy I." <[log in to unmask]>

Reply-To:

Software for the Heavy Photon Search Experiment <[log in to unmask]>

Date:

Fri, 22 May 2015 21:07:50 +0000

Content-Type:

text/plain

Parts/Attachments:

Parts/Attachments

text/plain (1 lines)

Hi, Holly.

There's a utility Driver you can use now for copying any cluster collection into a new one via your steering job....

<driver name="CopyClusters" type="org.hps.recon.ecal.cluster.CopyClusterCollectionDriver">
<inputCollectionName>EcalClusters</inputCollectionName>
<outputCollectionName>EcalClustersCopy</outputCollectionName>
<storeHits>true</storeHits>
</driver>

The "storeHits" argument controls whether or not the hits in the new collection are persisted in the LCIO output, but it does not affect the in-memory hit list which is always copied to the new cluster. (You can just ignore that hit list in your Driver if you don't need to use it.)

I added a copy constructor to BaseCluster in lcsim in order to more easily support this. The data structures (lists and arrays) from the source clusters are themselves copied to avoid unwanted direct references to objects in the original cluster. So you should be able to change the data in the new cluster collection including all its lists and arrays, without it affecting the old clusters. For energy and other primitives this wouldn't be a problem as these are not referenced objects. The hits themselves are *not* copied so they remain references but are put into a new list. I hope that all makes sense.

I verified in a simple test that I can run this Driver using the LCSimLoop on some recon output and get the output clusters with and without the hits stored, so it seems to work fine.

Can you confirm if this works for you?

--Jeremy

-----Original Message-----
From: Holly Vance [mailto:[log in to unmask]]
Sent: Friday, May 22, 2015 12:49 PM
To: McCormick, Jeremy I.
Subject: Re: collection issue

Thanks!

On Fri, May 22, 2015 at 3:43 PM, McCormick, Jeremy I. <[log in to unmask]> wrote:


There is an added complication here, because you can't just copy the Cluster objects into a new list. You need to perform a more low-level copy that actually makes new lists/arrays/etc. in the new object because otherwise the old objects are referenced directly from the new object, and you will really confuse yourself e.g. you'll modify something in the new cluster and it will also affect the old one!

I can handle this though...just give me a day or two to code something up and put it into the BaseCluster class which will handle this correctly. Then writing the copy Driver will be straightforward.

-----Original Message-----
From: Holly Vance [mailto:[log in to unmask]]

Sent: Friday, May 22, 2015 12:29 PM
To: McCormick, Jeremy I.
Subject: Re: collection issue

Is it just not possible to be done in the ClusterDriver? I think the way I wrote it in there, it should work, but for some reason it always outputs only 1 collection. Do you know why that behavior happens? It's not clear to me.

On Fri, May 22, 2015 at 3:25 PM, McCormick, Jeremy I. <[log in to unmask]> wrote:


ClusterDriver probably has enough functionality in it already without adding more to it....

I would keep it separate and have a new CopyClusterCollectionDriver that does this which can be run after the clustering is done. It could have the input and output cluster collection names. That's a more flexible way to do it.

-----Original Message-----
From: Holly Vance [mailto:[log in to unmask]]
Sent: Friday, May 22, 2015 12:23 PM
To: McCormick, Jeremy I.

Subject: Re: collection issue

Ok I thought it would be simlpler to add this feature to overall clustering.

I made my changes to ClusterDriver in my users folder. I can move it to a new driver, but I strongly feel like this is a feature that should not become too complicated. It makes sense that when you run a particular cluster driver, you could choose to output it its results to another collection for use in cluster track matching (effectively choosing this cluster collection).



On Fri, May 22, 2015 at 2:53 PM, McCormick, Jeremy I. <[log in to unmask]> wrote:


I think what you actually want to do here is not directly modify ClusterDriver itself but add a downstream Driver which knows the original cluster collection name and can read/copy it. That way we can leave ClusterDriver alone.


-----Original Message-----
From: Holly Vance [mailto:[log in to unmask]]
Sent: Friday, May 22, 2015 11:46 AM
To: McCormick, Jeremy I.
Subject: collection issue

Hi Jeremy,

I am trying to add a second cluster collection output in the simplest way possible such that it is a copy of what is in ReconCluster output and the position and energy information can be modified at cluster-track matching without hurting the orignal information.

So I added a new boolean variable to ClusterDriver and a new cluster collection output name.

Where we write: event.put ()
I added an if statement after this (if boolean, then) where this same cluster list can be added to this new output collection.

Unfortunately, it will only write one cluster collection when the driver is run. I don't know where this behavior is restricted, and I was wondering if you had advice.

-Holly




--






--






--
BEGIN-ANTISPAM-VOTING-LINKS
------------------------------------------------------

NOTE: This message was trained as non-spam. If this is wrong,
please correct the training as soon as possible.


Teach CanIt if this mail (ID 01Ov7J7w5) is spam:
Spam: https://www.spamtrap.odu.edu/canit/b.php?i=01Ov7J7w5&m=bd9621efc037&t=20150522&c=s
Not spam: https://www.spamtrap.odu.edu/canit/b.php?i=01Ov7J7w5&m=bd9621efc037&t=20150522&c=n
Forget vote: https://www.spamtrap.odu.edu/canit/b.php?i=01Ov7J7w5&m=bd9621efc037&t=20150522&c=f
------------------------------------------------------
END-ANTISPAM-VOTING-LINKS





########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the HPS-SOFTWARE list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1

Top of Message | Previous Page | Permalink

Advanced Options


Options

Log In

Log In

Get Password

Get Password


Search Archives

Search Archives


Subscribe or Unsubscribe

Subscribe or Unsubscribe


Archives

April 2024
March 2024
February 2024
January 2024
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
December 2022
November 2022
October 2022
September 2022
August 2022
June 2022
April 2022
March 2022
February 2022
January 2022
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011

ATOM RSS1 RSS2



LISTSERV.SLAC.STANFORD.EDU

Secured by F-Secure Anti-Virus CataList Email List Search Powered by the LISTSERV Email List Manager

Privacy Notice, Security Notice and Terms of Use