LISTSERV mailing list manager LISTSERV 16.5

Help for HPS-SOFTWARE Archives


HPS-SOFTWARE Archives

HPS-SOFTWARE Archives


HPS-SOFTWARE@LISTSERV.SLAC.STANFORD.EDU


View:

Message:

[

First

|

Previous

|

Next

|

Last

]

By Topic:

[

First

|

Previous

|

Next

|

Last

]

By Author:

[

First

|

Previous

|

Next

|

Last

]

Font:

Monospaced Font

LISTSERV Archives

LISTSERV Archives

HPS-SOFTWARE Home

HPS-SOFTWARE Home

HPS-SOFTWARE  October 2015

HPS-SOFTWARE October 2015

Subject:

Re: broken steering files

From:

Jeremy McCormick <[log in to unmask]>

Reply-To:

Software for the Heavy Photon Search Experiment <[log in to unmask]>

Date:

Thu, 8 Oct 2015 23:20:28 -0700

Content-Type:

text/plain

Parts/Attachments:

Parts/Attachments

text/plain (127 lines)

I agree. I would like to see a primary steering maintained for the current working version of the recon rather than new ones being made with copy and paste for every pass. If we want to recover a version that was used then we can get it from SVN in the tag of the trunk made by the hps Java release.

I understand the desire to create these very specific steering files but the possible consequence is that the old ones get abandoned and eventually stop working as the code changes.

> On Oct 8, 2015, at 6:02 PM, Maurik Holtrop <[log in to unmask]> wrote:
>
> Hi Jeremy,
>
> I have noticed the same issue with some of the older steering files. It seems that when the software is updated, a new steering file is created for the new software, instead of updating the existing steering file. So instead of always running EngineeringRun2015FullRecon.lcsim, we have been creating new versions: *_pass1, *_pass2, etc. This does have the benefit that it is easier to later find which steering file was used for a pass, although it should be that you could get this as well by checking out the correct release.
>
> I would suggest that we always have “EngineeringRun2015FullRecon.lsim” as the latest greatest (and working) steering file. So right now we could set it equal to "EngineeringRun2015FullRecon_Pass2.lsim”. And similar for the best MC steering file. That way we should always know which was the “best” steering file to run at any one point in the SVN history, even in between releases. Going forward, we should have a steering file for each data set if that data set requires changes from the default, and those should be maintained to work with every release.
>
> Cheers,
> Maurik
>
>
>> On Oct 8, 2015, at 7:41 PM, McCormick, Jeremy I. <[log in to unmask]> wrote:
>>
>> Hi, Nathan.
>>
>> The sandbox area is here.
>>
>> svn://svn.freehep.org/hps/java/sandbox
>>
>> And I'd make an "old_steering" dir under it for sandboxing the broken xml files.
>>
>> Broken recon steering files I found today which I plan to move there include:
>>
>> EngineeringRun2015FullRecon.lcsim
>> EngineeringRun2015FullReconOutsideIn.lcsim
>> HPS2014OfflineNoPileupRecon.lcsim
>> SimpleMCRecon.lcsim
>>
>> All with the null pointer bug due to being out of date with the current reconstruction.
>>
>> It seems to me maybe we should fix EngineeringRun2015FullRecon.lcsim though rather than sandbox it.
>>
>> The MC recon files that seemed to work or at least run without crashing included:
>>
>> EngineeringRun2014EcalReconMC.lcsim
>> EngineeringRun2015FullReconMC_Pass2.lcsim
>> EngineeringRun2015FullReconMC.lcsim
>> HPS2014OfflineTruthRecon.lcsim
>>
>> And this one works fine that runs on SLIC output without readout sim:
>>
>> /org/hps/steering/readout/HPSReconNoReadout.lcsim
>>
>> And these ones seem to work okay that run on the data:
>>
>> EngineeringRun2014EcalRecon_Pass1.lcsim
>> EngineeringRun2015FullRecon_Pass2.lcsim
>> EngineeringRun2015HitRecon.lcsim
>> GBLReco.lcsim
>> HPSTrackingDefaultsRecon.lcsim
>>
>> I'm planning on adding to the build a few tests that will run the working ones on a few events so that we will know if they break.
>>
>> I haven't checked steering files from the other different directories, but I assume that many are out of date and broken.
>>
>> The user steering areas are probably fine as is and don't need to be checked. It is each person's responsibility to keep those up to date if they wish.
>>
>> If anyone knows of other steering files that are broken or should be checked during the Hudson builds please let me know.
>>
>> --Jeremy
>>
>> -----Original Message-----
>> From: Nathan Baltzell [mailto:[log in to unmask]]
>> Sent: Thursday, October 08, 2015 4:31 PM
>> To: McCormick, Jeremy I.
>> Subject: Re: broken steering files
>>
>> I vote for freely moving all broken steering files in "production" to a sandbox in svn and NOT deleted.
>> But first it needs to be announced where this sandbox is.
>>
>> -nathan
>>
>>
>>
>>> On Oct 8, 2015, at 4:06 PM, "McCormick, Jeremy I." <[log in to unmask]> wrote:
>>>
>>> Hi,
>>>
>>> I noticed that a couple of the old recon prod steering files don't work anymore.
>>>
>>> EngineeringRun2015FullRecon.lcsim
>>> EngineeringRun2015FullReconOutsideIn.lcsim
>>>
>>> with error
>>>
>>> java.lang.NullPointerException
>>> at org.hps.recon.utils.TrackClusterMatcher.isMatch(TrackClusterMatcher.java:207)
>>> at org.hps.recon.particle.ReconParticleDriver.makeReconstructedParticles(ReconParticleDriver.java:264)
>>> at org.hps.recon.particle.ReconParticleDriver.process(ReconParticleDriver.java:422)
>>> at org.hps.recon.particle.HpsReconParticleDriver.process(HpsReconParticleDriver.java:132)
>>>
>>> These are not backward compatible with the current version of the recon.
>>>
>>> The Pass1 steering files seem fine.
>>>
>>> Should the broken files be deleted or sandboxed?
>>>
>>> I was planning to make an "old_steering" dir in the sandbox and move broken stuff there until it is fixed.
>>>
>>> I'm going to try and test the MC ones next....
>>>
>>> --Jeremy
>>>
>>> ########################################################################
>>> Use REPLY-ALL to reply to list
>>>
>>> To unsubscribe from the HPS-SOFTWARE list, click the following link:
>>> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1
>>
>> ########################################################################
>> Use REPLY-ALL to reply to list
>>
>> To unsubscribe from the HPS-SOFTWARE list, click the following link:
>> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1
>

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the HPS-SOFTWARE list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1

Top of Message | Previous Page | Permalink

Advanced Options


Options

Log In

Log In

Get Password

Get Password


Search Archives

Search Archives


Subscribe or Unsubscribe

Subscribe or Unsubscribe


Archives

February 2024
January 2024
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
December 2022
November 2022
October 2022
September 2022
August 2022
June 2022
April 2022
March 2022
February 2022
January 2022
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011

ATOM RSS1 RSS2



LISTSERV.SLAC.STANFORD.EDU

Secured by F-Secure Anti-Virus CataList Email List Search Powered by the LISTSERV Email List Manager

Privacy Notice, Security Notice and Terms of Use