LISTSERV mailing list manager LISTSERV 16.5

Help for HPS-SOFTWARE Archives


HPS-SOFTWARE Archives

HPS-SOFTWARE Archives


HPS-SOFTWARE@LISTSERV.SLAC.STANFORD.EDU


View:

Message:

[

First

|

Previous

|

Next

|

Last

]

By Topic:

[

First

|

Previous

|

Next

|

Last

]

By Author:

[

First

|

Previous

|

Next

|

Last

]

Font:

Proportional Font

LISTSERV Archives

LISTSERV Archives

HPS-SOFTWARE Home

HPS-SOFTWARE Home

HPS-SOFTWARE  October 2015

HPS-SOFTWARE October 2015

Subject:

Re: cleanup of logging in hps-java

From:

"McCormick, Jeremy I." <[log in to unmask]>

Reply-To:

Software for the Heavy Photon Search Experiment <[log in to unmask]>

Date:

Wed, 7 Oct 2015 20:05:47 +0000

Content-Type:

text/plain

Parts/Attachments:

Parts/Attachments

text/plain (294 lines)

The level of a logger is not set from

Logger.getLogger("MyLogger");

Initially, it is null and the global level is used instead by design.

So if you are calling getLevel() in your code then you probably want to add a null pointer checks to guard against this.

if (LOGGER.getLevel() != null) {
    // do something
}

You can also statically set the log level so it is always defined

Logger LOGGER = ...;
static {
    LOGGER.setLevel(Level.INFO);
}

But I think that's not preferable because it will override any externally supplied config.

Every package in hps-java does have a default level which comes from

trunk/logging/src/main/resources/org/hps/logging/config/logging.properties

provided you set the system property as I described or use one of the wrapper scripts from distribution.

Or you can override the default levels by providing your own custom config using

java -D -Djava.util.logging.config.file=mylogging.properties

There you can set the log level of all the packages in your custom config.

-----Original Message-----
From: Hansson Adrian, Per Ola 
Sent: Wednesday, October 07, 2015 12:56 PM
To: Nathan Baltzell
Cc: McCormick, Jeremy I.; hps-software
Subject: Re: cleanup of logging in hps-java


Just to reply that I worked around it in my specific case. 

I do want to mention why it was done and it's because if you have "slow" or expensive debug outputs changing the log level still processes those and by checking the log level explicitly I was circumventing that. 

I would expect there is a preferred way of dealing with this without having to have different command line options set each time.

I didn't look at the script and haven't really thought about it but why wouldn't we have a default level that can be overridden by developers as they like in different packages and in particular classes?

/Pelle


On Oct 7, 2015, at 12:42 PM, Nathan Baltzell <[log in to unmask]> wrote:

> Will you make it so the old command line still works?
> 
> 
> 
> On Oct 7, 2015, at 15:29, McCormick, Jeremy I. <[log in to unmask]> wrote:
> 
>> Yes, you should change it by adding the new Java property....
>> 
>> java 
>> -Djava.util.logging.config.class=org.hps.logging.config.DefaultLoggin
>> g -jar hps-distribution-bin.jar org.hps.evio.EvioToLcio [args]
>> 
>> Or if trunk/distribution is available run it from the generated script which does this automatically.
>> 
>> -----Original Message-----
>> From: Nathan Baltzell [mailto:[log in to unmask]]
>> Sent: Wednesday, October 07, 2015 12:25 PM
>> To: McCormick, Jeremy I.
>> Cc: Hansson Adrian, Per Ola; hps-software
>> Subject: Re: cleanup of logging in hps-java
>> 
>> This does not require changing the command line used for EvioToLcio, right?
>> 
>> 
>> 
>> 
>> On Oct 7, 2015, at 15:21, McCormick, Jeremy I. <[log in to unmask]> wrote:
>> 
>>> The level on the logger is null here because it was never set.  Loggers that are created with getLogger() don't actually have a "default" level (it is null by default) and the global level will get used instead in this case.
>>> 
>>> So you have to load the new default config explicitly for all the package loggers to be assigned levels.
>>> 
>>> java
>>> -Djava.util.logging.config.class=org.hps.logging.config.DefaultLoggi
>>> ng
>>> Config -jar [etc.]
>>> 
>>> Or you can instead run the wrapper script for EvioToLcio that's generated when you 'mvn' distribituion.
>>> 
>>> distribution/target/appassembler/bin/evio2lcio.sh
>>> 
>>> This script includes that bit of setup automatically, so that's probably the preferred option now for running EvioToLcio.
>>> 
>>> -----Original Message-----
>>> From: Hansson Adrian, Per Ola
>>> Sent: Wednesday, October 07, 2015 12:13 PM
>>> To: McCormick, Jeremy I.
>>> Subject: Re: cleanup of logging in hps-java
>>> 
>>> EvioToLcio run:
>>> 
>>> 
>>> Oct 07, 2015 12:05:07 PM org.hps.evio.LCSimEngRunEventBuilder
>>> makeLCSimEvent
>>> SEVERE: General error making SVT hits.
>>> java.lang.NullPointerException
>>> at
>>> org.hps.evio.SvtEventHeaderChecker.checkSvtHeaders(SvtEventHeaderChe
>>> ck
>>> er.java:89) at
>>> org.hps.evio.AugmentedSvtEvioReader.processSvtHeaders(AugmentedSvtEv
>>> io
>>> Reader.java:35) at
>>> org.hps.evio.AbstractSvtEvioReader.makeHits(AbstractSvtEvioReader.ja
>>> va
>>> :286) at
>>> org.hps.evio.LCSimEngRunEventBuilder.makeLCSimEvent(LCSimEngRunEvent
>>> Bu
>>> ilder.java:157) at org.hps.evio.EvioToLcio.run(EvioToLcio.java:572)
>>> at org.hps.evio.EvioToLcio.main(EvioToLcio.java:94)
>>> 
>>> 
>>> Actually the error happens on line 87 and not 89 (I added a debug to check exactly what did it).
>>> 
>>> /Pelle
>>> 
>>> On Oct 7, 2015, at 12:10 PM, McCormick, Jeremy I. <[log in to unmask]> wrote:
>>> 
>>> 
>>> 	Yeah, I tested it.  Where are you seeing this?
>>> 	
>>> 	-----Original Message-----
>>> 	From: Hansson Adrian, Per Ola 
>>> 	Sent: Wednesday, October 07, 2015 12:04 PM
>>> 	To: McCormick, Jeremy I.
>>> 	Subject: Re: cleanup of logging in hps-java
>>> 	
>>> 	
>>> 	Did you try running after updating? I get null pointer exceptions everywhere this is called?
>>> 	
>>> 	LOGGER.getLevel().intValue()
>>> 	
>>> 	
>>> 	On Oct 7, 2015, at 11:57 AM, McCormick, Jeremy I. <[log in to unmask]> wrote:
>>> 	
>>> 	
>>> 	I moved all the rest of the tracking detector classs to lcsim too, 
>>> so you should probably be more worried about that.  :)
>>> 	
>>> 	-----Original Message-----
>>> 	From: Hansson Adrian, Per Ola 
>>> 	Sent: Wednesday, October 07, 2015 11:56 AM
>>> 	To: McCormick, Jeremy I.
>>> 	Subject: Re: cleanup of logging in hps-java
>>> 	
>>> 	
>>> 	oh man...
>>> 	
>>> 	On Oct 6, 2015, at 6:56 PM, McCormick, Jeremy I. <[log in to unmask]> wrote:
>>> 	
>>> 	
>>> 	
>>> 	Hi,
>>> 	
>>> 	I cleaned up how we are using the Java logging API in HPS Java today by doing the following....
>>> 	
>>> 	1) Usage of the the LogUtil class from lcsim was replaced by the Logger.getLogger() method.
>>> 	
>>> 	2) Naming of static Logger objects was standardized to "LOGGER" across all classes.
>>> 	
>>> 	3) Classes will now create or use a logger that is named for their package rather than their class name e.g.
>>> 	
>>> 	private static final Logger LOGGER = 
>>> 	Logger.getLogger(MyClass.class.getPackage().getName());
>>> 	
>>> 	instead of
>>> 	
>>> 	Logger.getLogger(MyClass.class.getName());
>>> 	
>>> 	This makes it much easier to configure the logging output for sets of related classes by their package rather than needing to set levels for every class.
>>> 	
>>> 	4) A new logging module was added to the build, with a global logging 
>>> 	configuration file under
>>> 	
>>> 	
>>> logging/src/main/resources/org/hps/logging/config/logging.properties
>>> 	
>>> 	which contains default log levels for all hps-java packages.
>>> 	
>>> 	5) A default log setup class was added under
>>> 	
>>> 	
>>> logging/src/main/java/org/hps/logging/config/DefaultLoggingConfig.ja
>>> va
>>> 	
>>> 	which loads the classpath resource from #4 that provides global defaults.
>>> 	
>>> 	This will be automatically activated for all test cases, and it will also be setup automatically by the wrapper scripts generated from the distribution build (under target/appengine/bin).
>>> 	
>>> 	6) The methods for setting the log level on the DatabaseConditionsManager were removed in favor of using the standard logging API.
>>> 	
>>> 	7) Custom log level settings on various classes were mostly removed in favor of using the levels defined in the logging.properties classpath resource.
>>> 	
>>> 	8) There are no longer individual "handler" classes created for each logger.  There should be just one global console handler now, so the messages from different loggers should always show up in order.
>>> 	
>>> 	9) Related to #8, all of the calls to "logger.getHandlers[0]().flush()" were removed as they should no longer be needed.  The console output should be flushed predictably and automatically now.
>>> 	
>>> 	10) The default message format was changed so that the entire log record appears on a single line instead of two like before.
>>> 	
>>> 	For instance, here is a sample message
>>> 	
>>> 	INFO: I am enabled [Tue Oct 06 18:47:39 PDT 2015] org.hps.detector.svt.SvtDetectorSetup conditionsChanged                     
>>> 	
>>> 	The format is basically now: 
>>> 	
>>> 	LEVEL: MESSAGE [DATE] SOURCE
>>> 	
>>> 	We can change this easily in the properties file if a different format is desired (date printed first perhaps?).
>>> 	
>>> 	--
>>> 	
>>> 	That covers most of the changes that I made to the trunk.
>>> 	
>>> 	If you want to customize the logging behavior from jobs that are run with the "java -jar" command, there are two different settings that can be used.
>>> 	
>>> 	You can activate the default classpath resource as follows:
>>> 	
>>> 	java 
>>> 	-Djava.util.logging.config.class=org.hps.logging.config.DefaultLogging
>>> 	Config [args]
>>> 	
>>> 	Or you can provide your own customized logging properties file:
>>> 	
>>> 	java 
>>> 	-Djava.util.logging.config.class=org.hps.logging.config.file=mylogging
>>> 	.properties [args]
>>> 	
>>> 	There are more details about how this all works at the following URLs:
>>> 	
>>> 	includes details on setting the logging properties from the command 
>>> 	line 
>>> 	http://docs.oracle.com/javase/7/docs/api/java/util/logging/LogManager.
>>> 	html
>>> 	
>>> 	how to provide a custom formatting string for the mssages
>>> 	http://docs.oracle.com/javase/7/docs/api/java/util/logging/SimpleForma
>>> 	tter.html#format%28java.util.logging.LogRecord%29
>>> 	
>>> 	example of configuring logging via a properties file 
>>> 	http://tutorials.jenkov.com/java-logging/configuration.html
>>> 	
>>> 	Overall, the logging should now be much better organized and easier to configure, and it is more in line with how logging configuration is supposed to be done in Java applications, e.g. using the standard logging API and customizing the behavior via a properties file.
>>> 	
>>> 	You should definitely 'svn up' the hps-java trunk immediately to get these changes, as many files were changed and there is the possibility of (minor) conflicts having been created in your local copy.
>>> 	
>>> 	If you have any questions about these changes or need help/advice, then please let me know!
>>> 	
>>> 	--Jeremy
>>> 	
>>> 	######################################################################
>>> 	##
>>> 	Use REPLY-ALL to reply to list
>>> 	
>>> 	To unsubscribe from the HPS-SOFTWARE list, click the following link:
>>> 	
>>> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=
>>> 1
>>> 	
>>> 	
>>> 	
>>> 	
>>> 	
>>> 
>>> ####################################################################
>>> ##
>>> ##
>>> Use REPLY-ALL to reply to list
>>> 
>>> To unsubscribe from the HPS-SOFTWARE list, click the following link:
>>> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=
>>> 1
>> 
> 

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the HPS-SOFTWARE list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1

Top of Message | Previous Page | Permalink

Advanced Options


Options

Log In

Log In

Get Password

Get Password


Search Archives

Search Archives


Subscribe or Unsubscribe

Subscribe or Unsubscribe


Archives

April 2024
March 2024
February 2024
January 2024
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
December 2022
November 2022
October 2022
September 2022
August 2022
June 2022
April 2022
March 2022
February 2022
January 2022
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011

ATOM RSS1 RSS2



LISTSERV.SLAC.STANFORD.EDU

Secured by F-Secure Anti-Virus CataList Email List Search Powered by the LISTSERV Email List Manager

Privacy Notice, Security Notice and Terms of Use