Hi, Sebouh.

This seems like a worthy project, but I'd really recommend this be done first on an SVN branch so you can commit the changes and then people can test it.  Once we are satisfied everything is working properly then you can merge back into trunk.  You are likely to break things even if you don't mean to (I say this from experience of breaking many things).

If you need help/advice about branching, then let me know.  It is not too difficult.

I do think modifying the existing steering files is the way to go here rather than having EcalRawConverter, EcalRawConverter2, etc. which is obviously kind of a mess.

Also, add a JIRA item if there isn't one already because this is pretty major change.  :)

Thanks.

--Jeremy

-----Original Message-----
From: [log in to unmask] [mailto:[log in to unmask]] On Behalf Of Sebouh Paul
Sent: Wednesday, October 19, 2016 5:52 PM
To: Maurik Holtrop
Cc: hps-software
Subject: Re: Software Meeting, Thursday 9am/noon/6pm.

i'd like to add this:  

Breaking the EcalRawConverter into three drivers:
1)  EcalRawConverterDriver:  converts raw hits into CalorimeterHits (without doing the gains or any time corrections) by doing pulse fitting and pedestal subtraction.  The method getEnergy() for these hits will return the integrated ADC values instead of the energy in GeV, contrary to the API.  This is ok, since this collection is transient.  
2)  EcalGainsDriver.  multiplies the integrated ADC values from the previous driver by the gains from the database (or whatever source you configure it to get them from.  The output collection of this driver is also transient.  
3)  EcalTimeCorrectionDriver:  does the corrections on the hit times (time walk, etc).  The output collection of this driver is EcalCalHits, which is persistent. 

Originally, EcalRawConverterDriver did all three of these things.  I plan to commit these changes to the repository, with all the steering files (except for users directory steering files) modified to include the latter two drivers.  This will include the readout, recon, monitoring, and analysis steering files.  

We can talk more about this tomorrow.  

On Wed, Oct 19, 2016 at 1:44 PM, Maurik Holtrop <[log in to unmask]> wrote:


	Dear HPS Software Group,

	We will have our regular HPS Software meeting this Thursday, 9am Pacific, noon East Coast, 6pm Europe.

	Agenda:
	
	

	1.	Sparsifying the LCIO output: What can be dropped?          — Sebouh, all
	2.	What, if anything, do need to add to the DST?                    — All 
	3.	Updates on detector geometry: V5 detector at 1.5mm        — Bradley

		1.	Status of MC production                                            — Bradley 

	4.	Questions?                                               -- All


	Please let me know if you would like to present something.

	The connection will be with BlueJeans. Connection details at:
	https://confluence.slac.stanford.edu/display/hpsg/Software+Meetings <https://confluence.slac.stanford.edu/display/hpsg/Software+Meetings> 

	Best,
	Maurik


________________________________


	Use REPLY-ALL to reply to list

	To unsubscribe from the HPS-SOFTWARE list, click the following link:
	https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1 <https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1>  



________________________________

Use REPLY-ALL to reply to list

To unsubscribe from the HPS-SOFTWARE list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1 


########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the HPS-SOFTWARE list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1