Branch: refs/heads/master
Home: https://github.com/xrootd/xrootd
Commit: 7820587863140c915a76ead1724056228df7baaf
https://github.com/xrootd/xrootd/commit/7820587863140c915a76ead1724056228df7baaf
Author: Brian Bockelman <[log in to unmask]>
Date: 2018-03-05 (Mon, 05 Mar 2018)
Changed paths:
M src/XrdHttp/XrdHttpReq.cc
M src/XrdHttp/XrdHttpReq.hh
Log Message:
-----------
Close file handle for simple HTTP reads.
If a client requested a single byte range which was less than
the filesize, then the file handle was never explicitly closed.
When the TCP connection was closed, all open file handles on the
bridge are automatically closed too. Hence, it seems like this is
a moot point - a transient "leak". However, we have observed some
clients (particularly: CVMFS) that hold open TCP connections for
hours or days, resulting in the "leak" of a file handle per read
operation. In some cases, the number of file handles leaked was in
the tens-of-thousands.
In addition to the obvious memory issues, this was observable in the
f-stream monitoring as the near-simultaneous closing of 10k file handles
caused UDP buffer overflows and dropped monitoring packets.
Commit: f4860902138e2d791ac4873a28de3117bd79a182
https://github.com/xrootd/xrootd/commit/f4860902138e2d791ac4873a28de3117bd79a182
Author: Fabrizio Furano <[log in to unmask]>
Date: 2018-03-16 (Fri, 16 Mar 2018)
Changed paths:
M src/XrdHttp/XrdHttpReq.cc
M src/XrdHttp/XrdHttpReq.hh
Log Message:
-----------
Merge pull request #664 from bbockelm/close_simple_reads
Close file handle for simple HTTP reads.
Compare: https://github.com/xrootd/xrootd/compare/c33e5856e17a...f4860902138e
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
|