LISTSERV mailing list manager LISTSERV 16.5

Help for XROOTD-DEV Archives


XROOTD-DEV Archives

XROOTD-DEV Archives


XROOTD-DEV@LISTSERV.SLAC.STANFORD.EDU


View:

Message:

[

First

|

Previous

|

Next

|

Last

]

By Topic:

[

First

|

Previous

|

Next

|

Last

]

By Author:

[

First

|

Previous

|

Next

|

Last

]

Font:

Proportional Font

LISTSERV Archives

LISTSERV Archives

XROOTD-DEV Home

XROOTD-DEV Home

XROOTD-DEV  May 2023

XROOTD-DEV May 2023

Subject:

[xrootd/xrootd] 409e33: [XrdSys] Avoid memory leak report in asan when ove...

From:

Guilherme Amadio <[log in to unmask]>

Reply-To:

xrootd developers' list for Scalla/xrootd repository and related issues <[log in to unmask]>

Date:

Mon, 8 May 2023 07:46:11 -0700

Content-Type:

text/plain

Parts/Attachments:

Parts/Attachments

text/plain (355 lines)

  Branch: refs/heads/master
  Home:   https://github.com/xrootd/xrootd
  Commit: 409e33095174dc11c17d579cbb1e71fdc8c8ad08
      https://github.com/xrootd/xrootd/commit/409e33095174dc11c17d579cbb1e71fdc8c8ad08
  Author: Elvin Sindrilaru <[log in to unmask]>
  Date:   2023-05-04 (Thu, 04 May 2023)

  Changed paths:
    M src/XrdSys/XrdSysE2T.cc

  Log Message:
  -----------
  [XrdSys] Avoid memory leak report in asan when overwriting the default message for EBADE.


  Commit: 5e96161d6f3209a03822198955f85afe32cf1459
      https://github.com/xrootd/xrootd/commit/5e96161d6f3209a03822198955f85afe32cf1459
  Author: Andrew Hanushevsky <[log in to unmask]>
  Date:   2023-05-07 (Sun, 07 May 2023)

  Changed paths:
    M src/XrdHttp/XrdHttpProtocol.cc

  Log Message:
  -----------
  [HTTP] Initialize SecEntity.addrInfo to vaoid SEGV; Fixes #1986


  Commit: 6e79fc5d62f5c3c4cdf844ab4a2318c144dc055f
      https://github.com/xrootd/xrootd/commit/6e79fc5d62f5c3c4cdf844ab4a2318c144dc055f
  Author: Andrew Hanushevsky <[log in to unmask]>
  Date:   2023-05-07 (Sun, 07 May 2023)

  Changed paths:
    M src/XrdXrootd/XrdXrootdTpcMon.cc

  Log Message:
  -----------
  [Server] Use correct format to print size_t; fixes #1989


  Commit: 5663ee27f6a3d25291ce19751aa0bb344370d72b
      https://github.com/xrootd/xrootd/commit/5663ee27f6a3d25291ce19751aa0bb344370d72b
  Author: David Smith <[log in to unmask]>
  Date:   2023-05-07 (Sun, 07 May 2023)

  Changed paths:
    M src/XrdApps/XrdClProxyPlugin/ProxyPrefixFile.hh

  Log Message:
  -----------
  [XrdApps] Let XrdClProxyPlugin work with PgRead, adding some missing methods


  Commit: 11273fdac41ef9598e62a75b0a594d5ad6690dd7
      https://github.com/xrootd/xrootd/commit/11273fdac41ef9598e62a75b0a594d5ad6690dd7
  Author: David Smith <[log in to unmask]>
  Date:   2023-05-07 (Sun, 07 May 2023)

  Changed paths:
    M src/XrdXrootd/XrdXrootdFile.cc

  Log Message:
  -----------
  [Server] Allow XrdXrootdFile::Serialize() to used to wait more than once


  Commit: 390e55e8ab4a7a4f222b1ab705f8a26f5c98fca1
      https://github.com/xrootd/xrootd/commit/390e55e8ab4a7a4f222b1ab705f8a26f5c98fca1
  Author: David Smith <[log in to unmask]>
  Date:   2023-05-07 (Sun, 07 May 2023)

  Changed paths:
    M src/XrdCl/XrdClChannel.cc

  Log Message:
  -----------
  [XrdCl] Avoid possibility of Channel unregistering the wrong task


  Commit: e15120b1ae8ee5bc988aa7f9e5292dcfad7f8c18
      https://github.com/xrootd/xrootd/commit/e15120b1ae8ee5bc988aa7f9e5292dcfad7f8c18
  Author: David Smith <[log in to unmask]>
  Date:   2023-05-07 (Sun, 07 May 2023)

  Changed paths:
    M src/XrdXrootd/XrdXrootdFile.cc

  Log Message:
  -----------
  [Server] Correct the fh returned when reusing a handle from external table


  Commit: 2810d2d9c00dda39006facbd39d65c0482e66952
      https://github.com/xrootd/xrootd/commit/2810d2d9c00dda39006facbd39d65c0482e66952
  Author: Guilherme Amadio <[log in to unmask]>
  Date:   2023-05-07 (Sun, 07 May 2023)

  Changed paths:
    M src/XrdMacaroons/XrdMacaroonsAuthz.hh
    M src/XrdPosix/XrdPosixFile.hh
    M src/XrdPss/XrdPss.hh
    M src/XrdXrootd/XrdXrootdAioBuff.hh
    M src/XrdXrootd/XrdXrootdProtocol.hh

  Log Message:
  -----------
  Fix Clang -Winconsistent-missing-override warnings

Example warning:

In file included from .../XrdXrootdAioTask.cc:42:
src/XrdXrootd/XrdXrootdAioBuff.hh:51:25:
  warning: 'Recycle' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
virtual void            Recycle();
                        ^
src/XrdSfs/XrdSfsAio.hh:79:14: note: overridden virtual function is here
virtual void Recycle() = 0;


  Commit: 9adf6bc4f98d3c32ca4791b6957dc0f8259b92e7
      https://github.com/xrootd/xrootd/commit/9adf6bc4f98d3c32ca4791b6957dc0f8259b92e7
  Author: Guilherme Amadio <[log in to unmask]>
  Date:   2023-05-07 (Sun, 07 May 2023)

  Changed paths:
    M src/XrdXrootd/XrdXrootdProtocol.cc

  Log Message:
  -----------
  Fix Clang -Wbraced-scalar-init warning

 src/XrdXrootd/XrdXrootdProtocol.cc:1504:25:
   warning: braces around scalar initializer [-Wbraced-scalar-init]
    linkAioReq         = {0};


  Commit: b184d45892bc982efe6cbe3a99f5fbf641b54c40
      https://github.com/xrootd/xrootd/commit/b184d45892bc982efe6cbe3a99f5fbf641b54c40
  Author: Guilherme Amadio <[log in to unmask]>
  Date:   2023-05-07 (Sun, 07 May 2023)

  Changed paths:
    M src/XrdPosix/XrdPosixAdmin.cc

  Log Message:
  -----------
  [XrdPosix] Fix Clang -Wtautological-constant-out-of-range-compare warning

src/XrdPosix/XrdPosixAdmin.cc:71:10: warning: result of comparison of constant
32940614417338485 with expression of type 'unsigned int' is always false
[-Wtautological-constant-out-of-range-compare]

   if (i > std::numeric_limits<ptrdiff_t>::max() / sizeof(XrdCl::URL))
       ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Here std::numeric_limits<ptrdiff_t>::max() / sizeof(XrdCl::URL) == 32940614417338485,
which is bigger than the largest unsigned int, therefore the
comparison will always be false. We need i to be able to hold large
enough values. Fixes 0dc292fbf63d25c6a9e000a2e66d7e3e0b8db735.


  Commit: 6f61cb3afe37d5150cd9ceafbf4f720268e80097
      https://github.com/xrootd/xrootd/commit/6f61cb3afe37d5150cd9ceafbf4f720268e80097
  Author: Guilherme Amadio <[log in to unmask]>
  Date:   2023-05-07 (Sun, 07 May 2023)

  Changed paths:
    M src/XrdSecgsi/XrdSecgsiGMAPFunDN.cc

  Log Message:
  -----------
  [XrdSecgsi] Fix Clang -Wfortify-source warning

src/XrdSecgsi/XrdSecgsiGMAPFunDN.cc:207:40: warning: 'sscanf' may overflow;
destination buffer in argument 3 has size 4096, but the corresponding specifier
may require size 4097 [-Wfortify-source]
         if (sscanf(l, "%4096s %256s", val, usr) >= 2) {
                                       ^


  Commit: 78a77d7c9d6724a3df46d4fc26f11f117bbb9e75
      https://github.com/xrootd/xrootd/commit/78a77d7c9d6724a3df46d4fc26f11f117bbb9e75
  Author: Guilherme Amadio <[log in to unmask]>
  Date:   2023-05-07 (Sun, 07 May 2023)

  Changed paths:
    M tests/XrdClTests/FileCopyTest.cc

  Log Message:
  -----------
  [Tests] Fix typo in FileCopy test

Caught by a warning in Clang:

tests/XrdClTests/FileCopyTest.cc:400:62: warning: variable 'st'
is uninitialized when used within its own initialization [-Wuninitialized]
    CPPUNIT_ASSERT_XRDST( status.status == XrdCl::stError && st.code == XrdCl::errNotFound );
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tests/XrdClTests/../common/CppUnitXrdHelpers.hh:36:28:
 note: expanded from macro 'CPPUNIT_ASSERT_XRDST'

  XrdCl::XRootDStatus st = x;


  Commit: 60097be0806b7c27979ae125439fda094c8eac15
      https://github.com/xrootd/xrootd/commit/60097be0806b7c27979ae125439fda094c8eac15
  Author: Guilherme Amadio <[log in to unmask]>
  Date:   2023-05-07 (Sun, 07 May 2023)

  Changed paths:
    M tests/common/CppUnitXrdHelpers.hh

  Log Message:
  -----------
  [Tests] Change name of macro local variable to avoid clashes

The name st is used extensively throughout the code, so
using the same name here can cause shadowing problems or
hide typos like the one fixed in the previous commit.


  Commit: c1d12a3f58138483fd60e29709f3848a9cf1c1ae
      https://github.com/xrootd/xrootd/commit/c1d12a3f58138483fd60e29709f3848a9cf1c1ae
  Author: Guilherme Amadio <[log in to unmask]>
  Date:   2023-05-07 (Sun, 07 May 2023)

  Changed paths:
    M src/XrdPosix/XrdPosixPreload.cc
    M src/XrdPosix/XrdPosixPreload32.cc

  Log Message:
  -----------
  [XrdPosix] Fix build with Clang and _FORTIFY_SOURCE enabled

Some of the checks added by defining _FORTIFY_SOURCE break the
build with clang with errors like the one shown below. See the
manual page for feature_test_macros(7) for more information.

xrootd/src/XrdPosix/XrdPosixPreload32.cc:375:9:
  error: redefinition of a 'extern inline' function 'pread' is not supported in C++
ssize_t pread(int fildes, void *buf, size_t nbyte, off_t offset)
        ^
/usr/include/bits/unistd.h:72:1: note: previous definition is here
pread (int __fd, void *__buf, size_t __nbytes, __off_t __offset)
^

Since distributions enable _FORTIFY_SOURCE by default, it's better
to disable it for the XrdPosix plugin when using clang. Builds with
GCC are not affected by this problem.

Fixes #1975.


  Commit: 404bac4ef802124a1b13e9552993efa6a774f682
      https://github.com/xrootd/xrootd/commit/404bac4ef802124a1b13e9552993efa6a774f682
  Author: David Smith <[log in to unmask]>
  Date:   2023-05-07 (Sun, 07 May 2023)

  Changed paths:
    M src/XrdCl/XrdClAsyncSocketHandler.cc
    M src/XrdCl/XrdClAsyncSocketHandler.hh
    M src/XrdCl/XrdClStream.cc
    M src/XrdCl/XrdClStream.hh

  Log Message:
  -----------
  [Client] Add return codes for error checking in the network Event handler


  Commit: 21ddb013e42f2861e17c3dcf167e53e91e483e23
      https://github.com/xrootd/xrootd/commit/21ddb013e42f2861e17c3dcf167e53e91e483e23
  Author: Guilherme Amadio <[log in to unmask]>
  Date:   2023-05-07 (Sun, 07 May 2023)

  Changed paths:
    M bindings/python/src/PyXRootDEnv.hh

  Log Message:
  -----------
  [Python] Fix warning when building version string

xrootd/bindings/python/src/PyXRootDEnv.hh:137:66:
  warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
      static std::string verstr( XrdVERSION[0] == 'v' ? XrdVERSION + 1 : XrdVERSION );
                                                        ~~~~~~~~~~~^~~


  Commit: 6c6977e4c81f6ef70313b8b149866fa19ac869ba
      https://github.com/xrootd/xrootd/commit/6c6977e4c81f6ef70313b8b149866fa19ac869ba
  Author: David Smith <[log in to unmask]>
  Date:   2023-05-07 (Sun, 07 May 2023)

  Changed paths:
    M src/XrdCl/XrdClUtils.cc
    M src/XrdCl/XrdClUtils.hh
    M src/XrdCl/XrdClZipArchive.cc

  Log Message:
  -----------
  [Client] Avoid ZipArchive issuing VectorWrite which is too large during CloseArchive


  Commit: eeb85d2cb4631e8c96e58b3d404d013306827cf9
      https://github.com/xrootd/xrootd/commit/eeb85d2cb4631e8c96e58b3d404d013306827cf9
  Author: Guilherme Amadio <[log in to unmask]>
  Date:   2023-05-07 (Sun, 07 May 2023)

  Changed paths:
    M .github/workflows/build.yml

  Log Message:
  -----------
  [CI] Do not update pip, setuptools, and wheel for sdist build

The build no longer works with the latest versions of pip, setuptools,
and wheel due to usage of deprecated tools. This needs to be addressed
by modernizing our Python packaging (see issue #1844).


  Commit: d994dc9b02552c9958d1a77690f622040902e541
      https://github.com/xrootd/xrootd/commit/d994dc9b02552c9958d1a77690f622040902e541
  Author: Guilherme Amadio <[log in to unmask]>
  Date:   2023-05-07 (Sun, 07 May 2023)

  Changed paths:
    M docs/ReleaseNotes.txt

  Log Message:
  -----------
  Update release notes for v5.5.5


  Commit: 01a35b1f68a4c44dbe63ac0c438d6ab8eeab566a
      https://github.com/xrootd/xrootd/commit/01a35b1f68a4c44dbe63ac0c438d6ab8eeab566a
  Author: Guilherme Amadio <[log in to unmask]>
  Date:   2023-05-08 (Mon, 08 May 2023)

  Changed paths:
    M docs/PreReleaseNotes.txt
    M docs/ReleaseNotes.txt
    M src/XrdPss/XrdPss.hh

  Log Message:
  -----------
  Merge v5.5.5 into master


Compare: https://github.com/xrootd/xrootd/compare/ba9a39510b59...01a35b1f68a4

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1

Top of Message | Previous Page | Permalink

Advanced Options


Options

Log In

Log In

Get Password

Get Password


Search Archives

Search Archives


Subscribe or Unsubscribe

Subscribe or Unsubscribe


Archives

August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
December 2010
November 2010
October 2010
September 2010

ATOM RSS1 RSS2



LISTSERV.SLAC.STANFORD.EDU

Secured by F-Secure Anti-Virus CataList Email List Search Powered by the LISTSERV Email List Manager

Privacy Notice, Security Notice and Terms of Use