Print

---

In src/XrdClient/XrdClientConnMgr.cc I noticed the code:


XrdClientMessage *XrdClientConnectionMgr::ReadMsg(short int 
LogConnectionID)
{
    XrdClientLogConnection *logconn;
    XrdClientMessage *mex;

    logconn = GetConnection(LogConnectionID);

Somebody should check if logconn == 0, and take evasive action if it 
is. The WriteRaw method (right after it) does do this check. The error 
check will have to be propagated back through all the methods that call 
it, which will require some effort. (Throwing an exception might have 
been less grief...)

--
Gregory J. Sharp                   email: [log in to unmask]
Wilson Synchrotron Laboratory      url: 
http://www.lepp.cornell.edu/~gregor
Dryden Rd                          ph:  +1 607 255 4882
Ithaca, NY 14853                   fax: +1 607 255 8062