Print

Print


Commit in GeomConverter/src/org/lcsim/geometry on MAIN
IDDecoder.java+91.17 -> 1.18
todo list for old iddecoder class

GeomConverter/src/org/lcsim/geometry
IDDecoder.java 1.17 -> 1.18
diff -u -r1.17 -r1.18
--- IDDecoder.java	9 May 2007 00:59:58 -0000	1.17
+++ IDDecoder.java	15 Sep 2009 00:55:14 -0000	1.18
@@ -12,6 +12,15 @@
  * @author Tony Johnson
  * @author Jeremy McCormick
  */
+// TODO: The getX/Y/Z methods should be removed.  Instead use getPosition()[i] or getPositionVec.x/y/z().
+// TODO: The findCellContainingXYZ methods probably don't belong here.  In general, hard to implement and not always implemented by subclasses.
+// TODO: The field-related methods should be on IDDescriptor.  No need to push these methods up to here and clutters the interface.
+// TODO: The class hierarchy of implementations is overly complicated.  (CalorimeterIDDecoder, geometry.util, segmentation, etc.)
+// TODO: Needs a method to get the current id.
+// TODO: Methods like getSystemID() should use getValue("system") instead.  Same for getLayer().
+// TODO: The methods getPhi() and getTheta() can be easily computed from position or retrieved from position vector.
+// TODO: Need to find and refactor all code in lcsim and lcsim-contrib that uses methods to be deprecated or removed.
+// TODO: The method getSubdetector() needs to be revisted.  This should instead be retrieved from the hit's metadata.
 public interface IDDecoder
 {
     /** 
CVSspam 0.2.8