Print

---

Any chance of getting Brian's patch in?

----------------

Hi all,

CMS found an error in the XrdClient which is causing a segfault in our code. 
Here's the patch against our xrootd version:

http://brian-test.unl.edu/xrootd-readv2.patch

(this doesn't apply to trunk, but rather 20090727.1318) Basically, change 
this:

            Read_Async(reqvect[startitem].offset, reqvect[startitem].len);

to

            Read_Async(reqvect[startitem].offset, reqvect[startitem].len);
            res = reqvect[startitem].len;

Not setting res gives an incorrect return code from ReadV.  Unfortunately, 
TXNetFile kicks things back to TFile::ReadBuffers which, in ROOT 5.22, 
segfaults if given NULL input.

Brian
----- Original Message ----- 
From: "Wilko Kroeger" <[log in to unmask]>
To: "Lukasz Janyst" <[log in to unmask]>
Cc: <[log in to unmask]>
Sent: Tuesday, November 23, 2010 9:04 AM
Subject: Re: Building new xrootd version (v3.0.0)


>
> Hello Lukasz
>
>
> On Tue, 23 Nov 2010, Lukasz Janyst wrote:
>
>> Hi Wilko,
>>
>>   I have two things that I need to finish for this release... could
>> you wait till tomorrow?
>
> Yes. There is no rush changing it.
>
> Cheers,
>   Wilko
>
>
>> Cheers,
>>   Lukasz
>>
>> On Tue, Nov 23, 2010 at 5:55 PM, Wilko Kroeger <[log in to unmask]> 
>> wrote:
>>>
>>> Hello
>>>
>>> I am planning to build a new xrootd version from the current head
>>> (312eac7e4074df0b6c0d7ab38f6054c0ebbffed2). Please let me know if you 
>>> have
>>> any outstanding commits and would like me to wait a little bit.
>>>
>>> This will be the first version that is using the new tag format and I am
>>> planning to use "v3.0.0".
>>>
>>> Comments? Suggestions?
>>>
>>>
>>> Cheers,
>>> Wilko
>>>
>>