Hi,
I noticed the following lines:
%attr(-,xrootd,xrootd) %config(noreplace) %{_sysconfdir}/%{name}/xrootd-clustered.cfg
%attr(-,xrootd,xrootd) %config(noreplace) %{_sysconfdir}/%{name}/xrootd-standalone.cfg
%attr(-,xrootd,xrootd) %config(noreplace) %{_sysconfdir}/sysconfig/%{name}
(and corresponding ones for user daemon). I think it's an issue to have the service configuration file owned by the same user as the service itself. The running daemon should not have permission to write to its own configuration file.
There's plenty of precedence here: do an "ls -l" on /etc. At least locally, all files are owned by root.
Other than that, my cms packaging branch merged pretty cleanly for this update. Nits:
- Why did we change the instance name from "MAIN" to "DEFAULT"? I fear angry admins coming my way...
- The default logrotate options are "-k 7"; I had "-k 7 50m". Can we use my version?
- Our default configuration file changed from xrootd.cf to xrootd-clustered.cfg. Can we change it back? I again fear changing it twice on our admins in a short time period.
- I need to factor out my default CMS configurations into a separate RPM.
- I have "Obsoletes: xrootd" in my RPM. Thoughts?
Once I/We address the above issues, my local CMS packaging branch will likely be deleted.
Brian
