Print

Print


Commit in hps-java/src/main/java/org/lcsim/hps/recon/tracking on MAIN
HPSSVTSensorSetup.java+10-131.5 -> 1.6
just changes to comments and cleanup

hps-java/src/main/java/org/lcsim/hps/recon/tracking
HPSSVTSensorSetup.java 1.5 -> 1.6
diff -u -r1.5 -r1.6
--- HPSSVTSensorSetup.java	28 Feb 2012 00:03:15 -0000	1.5
+++ HPSSVTSensorSetup.java	1 Mar 2012 22:30:21 -0000	1.6
@@ -27,9 +27,10 @@
  * @author Mathew Graham <[log in to unmask]>
  * @author Omar Moreno   <[log in to unmask]>
  * @author Jeremy McCormick <[log in to unmask]>
- * @version $Id: HPSSVTSensorSetup.java,v 1.5 2012/02/28 00:03:15 jeremy Exp $
+ * @version $Id: HPSSVTSensorSetup.java,v 1.6 2012/03/01 22:30:21 jeremy Exp $
  */
-public class HPSSVTSensorSetup extends Driver {    
+public class HPSSVTSensorSetup extends Driver {
+	
     String subdetectorName = "Tracker";
     boolean debug = true;
     
@@ -81,7 +82,7 @@
      * @param subdetector  
      */
     private void configureSensors(Set<SiSensor> sensors) {
-        // Loop through all the sensors in the set
+        // Loop through all the sensors in the set.
         for(SiSensor sensor : sensors) {
             System.out.println("setting up sensor " + sensor.getName());
             // Set the sensor Id
@@ -92,20 +93,16 @@
             Polygon3D pSide = sensorSolid.getFacesNormalTo(new BasicHep3Vector(0, 0, 1)).get(0);
             Polygon3D nSide = sensorSolid.getFacesNormalTo(new BasicHep3Vector(0, 0, -1)).get(0);
             
-            // p side collects holes
+            // P side collects holes.
             sensor.setBiasSurface(ChargeCarrier.HOLE, pSide);
-            // n side collects electrons
+            // N side collects electrons.
             sensor.setBiasSurface(ChargeCarrier.ELECTRON, nSide);
             
             // Translate to the outside of the box in order to setup electrodes.
             ITranslation3D electrodesPosition = new Translation3D(VecOp.mult(-pSide.getDistance(), pSide.getNormal()));
-            //System.out.println("electrodes position...");
-            //System.out.println(electrodesPosition.toString());
             
-            // Align the strips with the edge of the sensor           
-            //IRotation3D electrodesRotation = new RotationPassiveXYZ(0, 0, Math.PI/2); // Is this the right rotation???
+            // Align the strips with the edge of the sensor.        
             IRotation3D electrodesRotation = new RotationPassiveXYZ(0, 0, 0);
-            //IRotation3D electrodesRotation = new RotationPassiveXYZ(0, 0, 0); // Is this the right rotation???
             Transform3D electrodesTransform = new Transform3D(electrodesPosition, electrodesRotation);
             
             // Set the number of readout and sense electrodes.
@@ -117,17 +114,17 @@
             	System.out.println(this.getClass().getName() + ": The number of sense strips are " + senseElectrodes.getNCells());
             }
 
-            // Set the strip capacitance
+            // Set the strip capacitance.
             readoutElectrodes.setCapacitanceIntercept(readoutStripCapacitanceIntercept);
             readoutElectrodes.setCapacitanceSlope(readoutStripCapacitanceSlope);
             senseElectrodes.setCapacitanceIntercept(senseStripCapacitanceIntercept);            
             senseElectrodes.setCapacitanceSlope(senseStripCapacitanceSlope); 
             
-            // Set sense and readout electrodes
+            // Set sense and readout electrodes.
             sensor.setSenseElectrodes(senseElectrodes);
             sensor.setReadoutElectrodes(readoutElectrodes);
             
-            // Set the charge transfer efficiency
+            // Set the charge transfer efficiency.
             double[][] transferEfficiencies = {{readoutTransferEfficiency, senseTransferEfficiency}};
             sensor.setTransferEfficiencies(ChargeCarrier.HOLE, new BasicMatrix(transferEfficiencies));
         }
CVSspam 0.2.12


Use REPLY-ALL to reply to list

To unsubscribe from the LCD-CVS list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=LCD-CVS&A=1