Print

Print


Commit in hps-java/src/main/java/org/lcsim/hps/monitoring on MAIN
ConnectionPanel.java+17-171.13 -> 1.14
ConnectionStatus.java+1-11.1 -> 1.2
ConnectionStatusPanel.java+1-11.2 -> 1.3
EventPanel.java+7-71.7 -> 1.8
JobPanel.java+8-81.5 -> 1.6
MonitoringApplication.java+10-171.19 -> 1.20
MonitoringCommands.java+6-61.5 -> 1.6
MonitoringPlotsDriver.java+13-131.2 -> 1.3
+63-70
8 modified files
change method and variable access to min required for MonitoringApp to run

hps-java/src/main/java/org/lcsim/hps/monitoring
ConnectionPanel.java 1.13 -> 1.14
diff -u -r1.13 -r1.14
--- ConnectionPanel.java	18 Apr 2012 19:52:15 -0000	1.13
+++ ConnectionPanel.java	18 Apr 2012 21:06:54 -0000	1.14
@@ -23,24 +23,24 @@
 
 class ConnectionPanel extends JPanel {
 
-    JTextField etNameField;
-    JTextField hostField;
-    JTextField portField;
-    JCheckBox blockingCheckBox;
-    JCheckBox verboseCheckBox;
-    JTextField statNameField;
-    JTextField chunkField;
-    JTextField qSizeField;
-    JTextField positionField;
-    JTextField ppositionField;
-    JComboBox waitComboBox; 
-    JTextField waitTimeField;
-    JTextField prescaleField;
+    private JTextField etNameField;
+    private JTextField hostField;
+    private JTextField portField;
+    private JCheckBox blockingCheckBox;
+    private JCheckBox verboseCheckBox;
+    private JTextField statNameField;
+    private JTextField chunkField;
+    private JTextField qSizeField;
+    private JTextField positionField;
+    private JTextField ppositionField;
+    private JComboBox waitComboBox; 
+    private JTextField waitTimeField;
+    private JTextField prescaleField;
+    
+    private ConnectionParameters connectionParameters;
 
-    ConnectionParameters connectionParameters;
-
-    boolean connectRequested = false;    
-    boolean disconnectRequested = false;
+    //private boolean connectRequested = false;    
+    //private boolean disconnectRequested = false;
 
     static final String[] waitModes = { 
         Mode.SLEEP.toString(), 

hps-java/src/main/java/org/lcsim/hps/monitoring
ConnectionStatus.java 1.1 -> 1.2
diff -u -r1.1 -r1.2
--- ConnectionStatus.java	8 Apr 2012 23:53:40 -0000	1.1
+++ ConnectionStatus.java	18 Apr 2012 21:06:54 -0000	1.2
@@ -1,6 +1,6 @@
 package org.lcsim.hps.monitoring;
 
-final public class ConnectionStatus
+final class ConnectionStatus
 {
     static final int DISCONNECTED = 0;
     static final int CONNECTED = 1;

hps-java/src/main/java/org/lcsim/hps/monitoring
ConnectionStatusPanel.java 1.2 -> 1.3
diff -u -r1.2 -r1.3
--- ConnectionStatusPanel.java	8 Apr 2012 23:48:11 -0000	1.2
+++ ConnectionStatusPanel.java	18 Apr 2012 21:06:54 -0000	1.3
@@ -38,7 +38,7 @@
         setStatus(ConnectionStatus.DISCONNECTED);
 	}
 	
-	public void setStatus(int idx) {
+	void setStatus(int idx) {
 		if (idx < 0 || idx > (ConnectionStatus.NUMBER_STATUSES - 1)) {
 			throw new IllegalArgumentException("Invalid index value.  Must be between 0 and " + (ConnectionStatus.NUMBER_STATUSES - 1) + ".");
 		}

hps-java/src/main/java/org/lcsim/hps/monitoring
EventPanel.java 1.7 -> 1.8
diff -u -r1.7 -r1.8
--- EventPanel.java	18 Apr 2012 19:52:15 -0000	1.7
+++ EventPanel.java	18 Apr 2012 21:06:54 -0000	1.8
@@ -12,13 +12,13 @@
 
 class EventPanel extends JPanel { 
 
-    private JTextField eventCounterField; // number of events in this job, can be reset via menu
-    private JTextField elapsedTimeField; // elapsed time between job start or reset command
-    private JTextField avgEventRateField; // average event rate in this job or between resets
+    private JTextField eventCounterField; // number of events in this job
+    private JTextField elapsedTimeField; // elapsed time between job start
+    private JTextField avgEventRateField; // average event rate in this job
     private JTextField refreshField; // number of events to wait before updating GUI
     private JTextField badEventsField; // number of bad events where event event processing failed
-    private JTextField sessionSuppliedField; // number of events supplied in this session, ignored by reset command
-    private JTextField totalSuppliedField; // number of events supplied since app started (this is never reset by any user command)
+    private JTextField sessionSuppliedField; // number of events supplied in this session; ignored by reset command
+    private JTextField totalSuppliedField; // number of events supplied since the application started
     
     private DecimalFormat rateFormat = new DecimalFormat("#.##");
    
@@ -30,7 +30,7 @@
     private int sessionSupplied;
     private int totalSupplied;
     
-    boolean updateEvent = true;
+    private boolean updateEvent = true;
     
     EventPanel() {
 
@@ -184,7 +184,7 @@
     	return eventRefresh;
     }
     
-    public void checkUpdateEvent() {
+    private void checkUpdateEvent() {
         updateEvent = ((eventCount % getEventRefresh()) == 0);
     }
     

hps-java/src/main/java/org/lcsim/hps/monitoring
JobPanel.java 1.5 -> 1.6
diff -u -r1.5 -r1.6
--- JobPanel.java	17 Apr 2012 18:12:41 -0000	1.5
+++ JobPanel.java	18 Apr 2012 21:06:54 -0000	1.6
@@ -17,18 +17,18 @@
 
 class JobPanel extends JPanel implements ActionListener {
 		
-	JComboBox steeringComboBox;
-	JTextField steeringField;
-	JTextField detectorNameField;
-	JTextField eventBuilderField;
-	JCheckBox logCheckBox;
-	JTextField logFileField;
+	private JComboBox steeringComboBox;
+	private JTextField steeringField;
+	private JTextField detectorNameField;
+	private JTextField eventBuilderField;
 	JCheckBox disconnectWarningCheckBox;	
 	JCheckBox disconnectOnErrorCheckBox;
+	JCheckBox logCheckBox;
+	JTextField logFileField;
 	
-	String defaultEventBuilderClassName = "";
+	private String defaultEventBuilderClassName = "";
 	
-	final static String[] steeringTypes = { "RESOURCE", "FILE", "NONE" };	
+	private final static String[] steeringTypes = { "RESOURCE", "FILE", "NONE" };	
 	final static int RESOURCE = 0;
 	final static int FILE = 1;
 	final static int NONE = 2;

hps-java/src/main/java/org/lcsim/hps/monitoring
MonitoringApplication.java 1.19 -> 1.20
diff -u -r1.19 -r1.20
--- MonitoringApplication.java	18 Apr 2012 19:52:15 -0000	1.19
+++ MonitoringApplication.java	18 Apr 2012 21:06:54 -0000	1.20
@@ -13,7 +13,7 @@
 import static org.lcsim.hps.monitoring.MonitoringCommands.savePlotsCmd;
 import static org.lcsim.hps.monitoring.MonitoringCommands.screenshotCmd;
 import static org.lcsim.hps.monitoring.MonitoringCommands.terminalCmd;
-import static org.lcsim.hps.monitoring.MonitoringCommands.updateTimerCmd;
+import static org.lcsim.hps.monitoring.MonitoringCommands.udpateTimeCmd;
 
 import java.awt.AWTException;
 import java.awt.Dimension;
@@ -172,7 +172,7 @@
 	        else if (exitCmd.equals(cmd)) {
 	            app.exit();
 	        }
-	        else if (updateTimerCmd.equals(cmd)) {
+	        else if (udpateTimeCmd.equals(cmd)) {
 	            app.updateTime();
 	        }
 	        else if (resetEventsCmd.equals(cmd)) {
@@ -202,20 +202,15 @@
 		// Setup the menus.
 		createMenu();
 		
-		//
-		// Connection status panel, placed at top.
-		//
-		
+		// Main panel.
 		GridBagConstraints c = new GridBagConstraints();
 		c.gridx = 0;
 		c.gridy = 0;
 		c.anchor = GridBagConstraints.NORTHWEST;
 		connectionStatusPanel = new ConnectionStatusPanel();
 		mainPanel.add(connectionStatusPanel, c);
-		
-		//
-		// Create a tab for each sub-panel.
-		//	
+	
+		// Sub-panels.
 		connectionPanel = new ConnectionPanel();
 		eventPanel = new EventPanel();
 		jobPanel = new JobPanel();
@@ -228,6 +223,7 @@
 		tabs.addTab("Job Settings", jobPanel);
 		tabsPanel.add(tabs);
 		
+		// Add tabs to main panel.
 		c = new GridBagConstraints();
 		c.gridx = 0;
 		c.gridy = 1;		
@@ -346,7 +342,7 @@
 	    connectionStatusPanel.setStatus(status);
 	}
 
-	int getConnectionStatus() {
+	private int getConnectionStatus() {
 	    return connectionStatus;
 	}
 	    
@@ -387,8 +383,8 @@
         }
     }
 
+    // FIXME: Put this in JobManager???
 	private synchronized void resetDrivers() {
-	    // FIXME: Put this in JobManager???
 		if (jobManager != null) {
 			for (Driver driver : jobManager.getDriverExecList()) {
 				if (driver instanceof Resettable) {
@@ -595,10 +591,7 @@
 	private void endEvent() {
 
 		// Update the average event rate.
-		eventPanel.updateAverageEventRate(jobStartTime);                    
-
-		// Update elapsed time.
-		//eventPanel.updateElapsedTime();
+		eventPanel.updateAverageEventRate(jobStartTime);
 	}
 	
 	private void badEvent() {
@@ -881,7 +874,7 @@
     
     private void startTimer() {
         timer = new Timer(1000, actionListener);
-        timer.setActionCommand(updateTimerCmd);
+        timer.setActionCommand(udpateTimeCmd);
         jobStartTime = System.currentTimeMillis();
         timer.start();
     }   

hps-java/src/main/java/org/lcsim/hps/monitoring
MonitoringCommands.java 1.5 -> 1.6
diff -u -r1.5 -r1.6
--- MonitoringCommands.java	18 Apr 2012 19:52:15 -0000	1.5
+++ MonitoringCommands.java	18 Apr 2012 21:06:54 -0000	1.6
@@ -15,13 +15,13 @@
 	static final String resetEventsCmd = "resetEvents";
 	static final String savePlotsCmd = "savePlots";
 	static final String resetDriversCmd = "resetDrivers";
-	static final String steeringCmd = "editSteering";
+	static final String steeringCmd = "steering";
 	static final String eventBuilderCmd = "eventBuilder";
-	static final String refreshCmd = "eventRefreshEdit";
+	static final String refreshCmd = "eventRefresh";
 	static final String exitCmd = "exit";
-	static final String logCmd = "editLogFile";
-	static final String terminalCmd = "terminalLog";
-	static final String screenshotCmd = "takeScreenshot";
+	static final String logCmd = "logFile";
+	static final String terminalCmd = "logTerminal";
+	static final String screenshotCmd = "screenshot";
 	static final String eventRefreshCmd = "eventRefreshEdit";
-	static final String updateTimerCmd = "updateTimer";
+	static final String udpateTimeCmd = "updateTime";
 }

hps-java/src/main/java/org/lcsim/hps/monitoring
MonitoringPlotsDriver.java 1.2 -> 1.3
diff -u -r1.2 -r1.3
--- MonitoringPlotsDriver.java	22 Mar 2012 22:03:35 -0000	1.2
+++ MonitoringPlotsDriver.java	18 Apr 2012 21:06:54 -0000	1.3
@@ -38,19 +38,19 @@
     private int eventCount;  
     private Detector detector = null;
     
-    IHistogram1D adcValuePlot; 
-    IHistogram1D rawHitCountPlot;
-    IHistogram1D tkrHitCountPlot;            
-    IHistogram1D tkrCountPlot;
-    ICloud1D hitsPerTrackPlot;
-    IHistogram1D tkrMomXPlot;
-    IHistogram1D tkrMomYPlot;
-    IHistogram1D tkrMomZPlot;
-    IHistogram1D tkrMomPlot;
-    ICloud1D timePlot;
-    ICloud1D ecalTimePlot;
-    ICloud1D ecalAmplitudePlot;
-    ICloud1D ecalHitsPlot;
+    private IHistogram1D adcValuePlot; 
+    private IHistogram1D rawHitCountPlot;
+    private IHistogram1D tkrHitCountPlot;            
+    private IHistogram1D tkrCountPlot;
+    private ICloud1D hitsPerTrackPlot;
+    private IHistogram1D tkrMomXPlot;
+    private IHistogram1D tkrMomYPlot;
+    private IHistogram1D tkrMomZPlot;
+    private IHistogram1D tkrMomPlot;
+    private ICloud1D timePlot;
+    private ICloud1D ecalTimePlot;
+    private ICloud1D ecalAmplitudePlot;
+    private ICloud1D ecalHitsPlot;
     
     protected void detectorChanged(Detector detector) {
         
CVSspam 0.2.12


Use REPLY-ALL to reply to list

To unsubscribe from the LCD-CVS list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=LCD-CVS&A=1