 |
 |
I concur with Serge on the point that this is a tentative logging solution, and therefore, its longterm extensibility is not a priority. I have no objections to hiding the inner classes and the static members you mentioned. -- Bill On Feb 4, 2014, at 6:17 PM, Serge Monkewitz <[log in to unmask]> wrote: > On Feb 4, 2014, at 5:04 PM, Daniel L. Wang <[log in to unmask]> wrote: > >> Hello, >> >> I was looking over the Logger class and was wondering if anyone had any objections to moving the declaration of some of Logger's internal classes (SyncSink, SeverityFilter, LogFilter) from Logger.h into Logger.cc. I'd also like to move the visibility of some of the static fields of Logger (syncSink, syncBuffer, and logStream) into Logger.cc. All of these seem like pieces that the Logger needs in order to operate, but that clients of Logger really shouldn't be messing with. >> >> In particular, I'd like to know if Bill (author) or Serge (reviewer) can point out what I missed. Perhaps there is flexibility to be had in exposing those classes/fields in Logger's public interface? > > Bill should clarify, but I think the idea was that one should be able to change the destination of log output from the default of std::cout. For that, at least logStream needs to be public, and then perhaps you'd want to be able to make a SyncBuffer (to handle locking writes to that stream for you). > > However, I don’t think this part of the code is very well fleshed out, and there are still Helgrind warnings coming out of it. It’s a stop-gap solution while waiting on the log4cpp work (but is nevertheless better than what we had before). With that in mind, I’m OK with removing flexibility and moving moving everything to the implementation file. > > Bill? > > ######################################################################## > Use REPLY-ALL to reply to list > > To unsubscribe from the QSERV-L list, click the following link: > https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=QSERV-L&A=1 ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the QSERV-L list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=QSERV-L&A=1