 |
 |
By email, review comments documented, best if directly inside the corresponding jira issue. You can see an example (of a long but very useful) review eg here: https://dev.lsstcorp.org/trac/ticket/3042 Here is an example of quick review: https://dev.lsstcorp.org/trac/ticket/2537 Jacek On 03/26/2014 03:21 PM, Salnikov, Andrei A. wrote: > OK, sounds easy :) Should this be done face-to-face or does it really > matter > > in this case? > > > Cheers, > Andy > > *From:*Becla, Jacek > *Sent:* Wednesday, March 26, 2014 3:11 PM > *To:* Salnikov, Andrei A. > *Cc:* qserv-l > *Subject:* RE: [QSERV-L] DM-296 > > Andy, > > Great. It is mostly about checking if the code is clean, if it follows > lsst coding standards; we also use it as a vehicle to learn from each > other. You don't need to do any verifications whether it works, this is > up to the person writing code. We try to keep reviews lightweight, > e.g. an hour or two, but sometimes we break this rule and end up with > monster reviews, like CSS. The name space review should be quick, I > hope. > > I'm sure KT will chime in about the review process :-) > > Jacek > > On Mar 26, 2014 3:02 PM, "Salnikov, Andrei A." > <[log in to unmask] <mailto:[log in to unmask]>> wrote: > > Hi Jacek, > > sorry, I accidentally clicked on a wrong button, you should have noticed :) > > I'd be happy to look at the code, is there anything specific about the > review process that I could learn? > > > Cheers, > Andy > > > Jacek Becla wrote on 2014-03-26: >> See >> >>https://jira.lsstcorp.org/browse/DM-296 >> >> It is ready for review. I am not sure who should review it... >> >> Daniel or Serge? Hmm, or perhaps AndyS? >> >> I'd vote for pushing it to master right after CSS. >> I would rather not deal with migrating the QMS which >> is still on the master.... >> >> >> Jacek >> >> ######################################################################## >> Use REPLY-ALL to reply to list >> >> To unsubscribe from the QSERV-L list, click the following link: >>https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=QSERV-L&A=1 > > ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the QSERV-L list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=QSERV-L&A=1