Print

Print


Hi Jacek -

See my answers below. . . 

On Mar 13, 2014, at 11:12 AM, Jacek Becla <[log in to unmask]> wrote:

> Bill,
> 
> Nice!
> 
> Is there any reason why the logging levels in your code
> 
> # logging levels
> TRACE = 0
> DEBUG = 1
> INFO = 2
> WARN = 3
> ERROR = 4
> FATAL = 5
> 
> are not aligned with standard python logging levels:
> 
> CRITICAL	50
> ERROR	40
> WARNING	30
> INFO	20
> DEBUG	10
> NOTSET	0
> 
> (http://docs.python.org/2/library/logging.html#logging-levels)
The logging levels used align to those of log4cxx, but do not believe there's anything special about these names.
(http://logging.apache.org/log4cxx/usage.html)
> 
> ---
> 
> Could we have date consistently formatted across languages?
> 
> 20140313 00:30:06,226
> 2014-03-05 17:04:32,380
Absolutely--the date/time format is very flexible.
> 
> ---
> 
> Did you put any thoughts into multi-threading support?
log4cxx, like log4j, is advertised as thread-safe. The thin-layer I built on top of log4cxx does not maintain state, and therefore, should not impact thread-safety.
> 
> ---
> 
> Minor comment: please update copyright info, eg
> 
> "Copyright 2008, 2009, 2010" --> "Copyright 2014"
Will do.
> 
> Jacek
> 
> 
> 
> 
> On 03/13/2014 01:17 AM, Bill Chickering wrote:
>> Hi Jacek -
>> 
>> Sorry for the delayed response.
>> 
>> I have pushed a new feature branch: u/bchick/protolog, which contains my implementation of the prototype logging mechanism built from log4cxx. There are important comments within README-protolog.txt found in the repo's root directory.
>> 
>> I look forward to demonstrating the prototype tomorrow.
>> 
>> -- Bill
>> 
>> 
>> On Mar 12, 2014, at 12:18 PM, Jacek Becla <[log in to unmask]> wrote:
>> 
>>> Bill
>>> 
>>> Is your latest log4cxx-based prototype somewhere in the repo
>>> where we could see it? The branch u/bchick/logging hasn't
>>> been changed since Sept of last year...
>>> 
>>> Thanks,
>>> Jacek
>> 
> 

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the QSERV-L list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=QSERV-L&A=1