Print

Print


Hello Daniel,

Thanks for this detailed and usefull report, you're perfectly right, 
there's a bug in the  the install procedure related to python path 
management. Nevertheless it applies only when "build_dir" parameter is a 
relative path, that's why it is quite difficult to discover.
I've added a quick fix directly in master branch, tested it 
successfully, and updated the install procedure. Hope it will cover all 
other possible cases.

Have a nice day,

Fabrice

On 04/18/2014 03:00 AM, Daniel L. Wang wrote:
> Fabrice,
>
>> - Daniel, please note that i had to undo your commit n° 
>> 63c51c29abfee5bc5573cc23413f8867f3b9d490, to make the system work 
>> with eups.
>
> Without my patch, the file seems to be installed in the wrong place:
> -----
> Install file: "bld2/_masterLib.so" as 
> "bld2/dist/bld2/dist/lib/python/lsst/qserv/master/_masterLib.so"
> ----
>
> Maybe there is some path-processing code that makes an inappropriate 
> assumption?
> In custom.py, I have set a custom build directory:
> ----
> build_dir="bld2"
> ----
>
> Also, it doesn't seem to make sense that the setting in 
> core/modules/SConscript for shProducts["_masterLib"] has:
>                                'distDir' : 
> os.path.join(env['python_prefix'],"lsst","qserv","master")
> but shProducts["xrdoss"] has:
>                            'distDir' : 'lib'
>
> I think it fails for me because site_scons/state.py sets:
>             (PathVariable('python_prefix', 'qserv install directory 
> for python modules', os.path.join(env['prefix'], "lib", "python"), 
> PathVariable.PathIsDirCreate))
>
> You can see that this makes the distDir setting for 
> shProducts["_masterLib"] incorrect, or at least inconsistent with 
> distDir settings elsewhere. I think in this case,
> 'distDir' : os.path.join("python", "lib", "lsst","qserv","master")
>
> might make more sense.
>
> What do you think?
> -Daniel
>
> ########################################################################
> Use REPLY-ALL to reply to list
>
> To unsubscribe from the QSERV-L list, click the following link:
> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=QSERV-L&A=1

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the QSERV-L list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=QSERV-L&A=1