 |
 |
Hi Jacek, does not boost come from system location (/usr/include) which is supposed to use <> include? There may be reasons to install non-system boost version at different location which makes that guideline difficult to follow. I think also that that particular guideline is not quite correct, in gcc the difference between "" and <> is only that "" searches local directory (directory which contains file being processed, not $PWD) first, and then it does exactly the same as <>. Another aspect of <> and "" difference is that scons (with the default dependency scanner) does not add <> headers into dependency list which helps to reduce number of dependencies to be checked. Also boost headers use <> to include other boost headers. Cheers, Andy Jacek Becla wrote on 2014-04-24: > I noticed we are inconsistent about <> vs "" when we > include boost, for example, in qserv, we have 146 <> > and 36 "". I peeked at afw, and it is also not > consistent either, although in the other direction: > 46 <> and 109 "". > > According to our coding standard 4.15 > > https://dev.lsstcorp.org/trac/wiki/C%2B%2BStandard/Files#a4-15.OnlysystemincludefilepathsSHALLbedelimitedwith > > we should be using "" for boost... > > I'm going to clean in in qserv. > > Jacek > > > > pwd > ~/work/lsst/software/qserv/core/modules > > grep 'include <boost' */* |wc > 146 314 7916 > grep 'include "boost' */* |wc > 36 79 2208 > pwd > ~/work/lsst/software/afw/src > > grep 'include <boost' */* |wc > 46 92 3256 > grep 'include "boost' */* |wc > 109 218 6053 > ######################################################################## > Use REPLY-ALL to reply to list > > To unsubscribe from the QSERV-L list, click the following link: > https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=QSERV-L&A=1 ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the QSERV-L list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=QSERV-L&A=1