 |
 |
Hi, Okay, Sho. I think I mostly agree with you. But I'm not sure that the Drivers which were copied are fully compatible with test run data anymore or if they do the same thing they did originally. I don't know in what way they were altered. And if they are part of some test run analysis, why are they living in a monitoring package? I would propose to move them from the monitoring package into the analysis module if they are in fact being used for test run analysis. Andrea, do you have some info here on exactly what was changed? I'm not trying to be a pain here, but I want to avoid a situation where we have Drivers with the same names, that kind of do the same thing, but live in different packages. This will potentially be very confusing for people actually trying to run and configure the monitoring app. --Jeremy -----Original Message----- From: Sho Uemura [mailto:[log in to unmask]] Sent: Thursday, June 05, 2014 6:32 PM To: McCormick, Jeremy I. Cc: andrea.celentano; hps-software Subject: RE: forked package Those drivers are part of the test run analysis and are still used for that purpose. Any that weren't copied should be kept. On Thu, 5 Jun 2014, McCormick, Jeremy I. wrote: > Hi, > Sho, what do you think of this? I know you wrote most of the ECAL monitoring drivers. Some of them were not copied to ecal.plots and only exist in drivers.ecal. > Is it okay to sandbox the "old" drivers.ecal package? Anything we need later could be moved back to trunk. > --Jeremy > > -----Original Message----- > From: andrea.celentano [mailto:[log in to unmask]] > Sent: Thursday, June 05, 2014 11:21 AM > To: McCormick, Jeremy I.; hps-software > Subject: R: forked package > > Hi, > The monitoring app drivers for ecal are in monitoring.ecal.plots I copied them from drivers.ecal at the beginning of the development. You can move drivers.ecal in the sandbox if you want, they are not needed any longer. > > Andrea > > > -------- Messaggio originale -------- > Da: "McCormick, Jeremy I." > Data:05/06/2014 20:00 (GMT+01:00) > A: hps-software > Oggetto: forked package > > Hi, > > Looking over some code today... > > It seems to me that org.hps.monitoring.drivers.ecal was forked into org.hps.monitoring.ecal.plots, as most of the classes are the same. I guess the ones in drivers.ecal were from the test run, but they are probably not needed any longer. > > One of these should be removed or they should both be combined into one package. Any opinions on this? > > --Jeremy > > ###################################################################### > ## > Use REPLY-ALL to reply to list > > To unsubscribe from the HPS-SOFTWARE list, click the following link: > https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1 > > > ###################################################################### > ## > Use REPLY-ALL to reply to list > > To unsubscribe from the HPS-SOFTWARE list, click the following link: > https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1 > ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the HPS-SOFTWARE list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1