 |
 |
Hi Fabrice, trailing witespaces are not as bad as tabs :) I agree that they should be removed and there is a setting in eclipse that does that automatically on every save but I tend top leave that setting off just beacuse it leads sometimes to too many witespace-only changes if the files that I edit have these spaces already. Concerning auto-install for dependencies it's of course very nice feature when you do 'eups distrib install'. I only wish we could auto-install dependencies when we do setup for the local clone. Maybe we should ask for this new feature to be added to eups (if it's not there already). Cheers, Andy From: Fabrice Jammes [mailto:[log in to unmask]] Sent: Thursday, June 05, 2014 12:42 AM To: Salnikov, Andrei A. Cc: qserv-l Subject: Re: [QSERV-L] (DM-742) Use geom eups package for installing geometry Hi Andy, Thanks for DM-751 fix, I've read your algorithm and I think it strenghten a lot boost libs detection. (I think that sconsUtils solves also this problem as it provides to the build script the name of the eups package libs, but integrating sconsUtils with Qserv scons script would be a complex job.) Thanks also for your remark about tabs I inadvertently insert in my code. I use several machines to develop and, indeed, I have to be carefull about my vi configuration on all of these. Please note that your DM-751 fix also introduced trailing-whitespaces in site_scons/detect.py. Maybe we should have a common pre-commit script to check our formatting is correct ? About point 3, I mainly agree with you. The method you described is fine when no Qserv dependencies are impacted. But please note that for DM-742 this method would have been quite complex. Indeed, in addition to Qserv, geom package had also to be setup from its own git repos (branch u/fjammes/DM-742), I should have specified this in the ticket comment. Nevertheless, I think that it's a good thing to run from scratch the whole install process, in peculiar when dependencies are impacted, but i'm not sure this is the reviewer job. For your information, Mario told me it should be possible to allow other lsst-dev users to easilly publish on Qserv distserver. Cheers, Fabrice On 06/05/2014 08:35 AM, Salnikov, Andrei A. wrote: Hi Fabrice, I made a fix for DM-751 today which finds correct boost libraries even if there are both system-installed boost and boost in stack. Daniel reviewed my changes and I merged them into master (and pushed to main repo). JIRA is not working so there is no record for that yet but you can try to pull most recent master and rebase your DM-742 branch, it should fix issue with boost that I saw. Concerning point 3 - I'm not sure that we need branches published on distserver, it feels like an extra step that you should do before we can review tickets. Also it looses git history, one would still have to clone that branch into separate location to be able to review the changes. Cheers, Andy From: [log in to unmask]<mailto:[log in to unmask]> [mailto:[log in to unmask]] On Behalf Of Fabrice Jammes Sent: Wednesday, June 04, 2014 11:22 PM To: qserv-l Subject: [QSERV-L] (DM-742) Use geom eups package for installing geometry Hello Andy and Jacek, Atlassian server is down, that's why i answer to your comment on DM-742 using qserv-l list. Here is some information on DM-742 that might help us to better converge : 1. Initial geometry.py install procedure was using wget. That's why I include DM-712<https://jira.lsstcorp.org/browse/DM-712> (wget/curl comment) in DM-742. This allowed me to avoid replacing wget with curl for geom. Instead I switched directly to eups. 2. Previous geom package was relying on boost, that's why I met and opened DM-751 while working on DM-742. Please note that a workaround to solve temporarily DM-751 is to uninstall system boost libraries. In order to detect this problem I had to add some debugging messages related to boost (and mysql ?), which are contained in DM-712. The only updates in DM-742 related to boost and MySQL are debug messages which doesn't impact the build scripts and only are printed using "scons --verbose". I propose to add previous comments in DM-712 description. 3. In order to install DM-742 version please run : eups distrib install qserv u.fjammes.DM-742-g71d79c6ef7+3 -r http://lsst-web.ncsa.illinois.edu/~fjammes/qserv<http://lsst-web.ncsa.illinois.edu/%7Efjammes/qserv> I think we could define a procedure to publish and install ticket branch from distserver. This would allow easier reviewing ? 4. Please note that geom package has also been simplified w.r.t. Paul Price informations. Please review branch u.fjammes.DM-74 in geom package. Dependencies to "utils" has been removed (utils was bringing several eups packages whose boost. This is how DM-751 bug was discovered) Have a nice day, Fabrice ________________________________ Use REPLY-ALL to reply to list To unsubscribe from the QSERV-L list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=QSERV-L&A=1 ________________________________ Use REPLY-ALL to reply to list To unsubscribe from the QSERV-L list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=QSERV-L&A=1 ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the QSERV-L list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=QSERV-L&A=1