 |
 |
Hi KT, Kian-Tat Lim wrote on 2014-06-05: > Andy, > >> Concerning point 3 - I'm not sure that we need branches published on >> distserver, it feels like an extra step that you should do before we can >> review tickets. Also it [loses] git history > > Why? buildbot can build from any branch (or combination > thereof). I don't see any impact on git at all. Or do you mean that > installing the code from the distribution server, even if it does > install the source somewhere, doesn't come with the git history? That I > agree with. Sorry, I was not clear. Yes I mean that once you install the package you have something that you can run but you do not have the code that you want to review. > >> one would still have to clone >> that branch into separate location to be able to review the changes. > > I would expect most reviewers would already have a clone, or > they could use a tool like cgit or Stash to look at the code without > their own local clone. Yes, you almost always need a clone and building something from a clone is the same amount of work as installing eups package. I personally still prefer to build/install locally when I do development or reviews. Cheers, Andy ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the QSERV-L list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=QSERV-L&A=1