Print

Print


Commit in java/trunk/conditions/src on MAIN
main/java/org/hps/conditions/svt/SvtDetectorSetup.java+32-111021 -> 1022
test/java/org/hps/conditions/svt/SvtDetectorSetupTest.java+14-101021 -> 1022
+46-21
2 modified files
Update SvtDetectorSetup so it uses the new SVT conditions API when loading conditions to an HpsSiSensor. The corresponding test was also updated.

java/trunk/conditions/src/main/java/org/hps/conditions/svt
SvtDetectorSetup.java 1021 -> 1022
--- java/trunk/conditions/src/main/java/org/hps/conditions/svt/SvtDetectorSetup.java	2014-09-14 08:00:06 UTC (rev 1021)
+++ java/trunk/conditions/src/main/java/org/hps/conditions/svt/SvtDetectorSetup.java	2014-09-14 08:03:37 UTC (rev 1022)
@@ -66,35 +66,56 @@
            
             // Set the FEB Hybrid ID of the sensor
             sensor.setFebHybridID(daqPair.getSecondElement());
+           
+            // Set the orientation of the sensor
+            String orientation = daqMap.getOrientation(daqPair);
+            if(orientation != null && orientation.contentEquals(SvtDaqMappingCollection.AXIAL)){
+            	sensor.setAxial(true);
+            } else if(orientation != null && orientation.contains(SvtDaqMappingCollection.STEREO)){
+            	sensor.setStereo(true);
+            }
 
             // Find all the channels for this sensor.
             Collection<SvtChannel> channels = channelMap.find(daqPair);
 
             // Loop over the channels of the sensor.
             for (SvtChannel channel : channels) {
-                // Get conditions data for this channel.
+                
+            	// Get conditions data for this channel.
                 ChannelConstants constants = conditions.getChannelConstants(channel);
                 int channelNumber = channel.getChannel();
 
                 //
                 // Set conditions data for this channel on the sensor object:
                 //
+                
+                // Check if the channel was flagged as bad
                 if (constants.isBadChannel()) {
                     sensor.setBadChannel(channelNumber);
                 }
-
-                /*
+                
+                // Set the pedestal and noise of each of the samples for the 
+                // channel
+                double[] pedestal = new double[6];
+                double[] noise = new double[6];
+                for(int sampleN = 0; sampleN < HpsSiSensor.NUMBER_OF_SAMPLES; sampleN++){
+                	pedestal[sampleN] = constants.getCalibration().getPedestal(sampleN);
+                	noise[sampleN] = constants.getCalibration().getNoise(sampleN);
+                }
+                sensor.setPedestal(channelNumber, pedestal);
+                sensor.setNoise(channelNumber, noise);
+               
+                // Set the gain and offset for the channel
                 sensor.setGain(channelNumber, constants.getGain().getGain());
-                sensor.setTimeOffset(channelNumber, constants.getGain().getOffset());
-                sensor.setNoise(channelNumber, constants.getCalibration().getNoise());
-                sensor.setPedestal(channelNumber, constants.getCalibration().getPedestal());
-                sensor.setPulseParameters(channelNumber, constants.getPulseParameters().toArray());
-                */
+                sensor.setOffset(channelNumber, constants.getGain().getOffset());
+               
+                // Set the shape fit parameters
+                sensor.setShapeFitParameters(channelNumber, constants.getShapeFitParameters().toArray());
             }
 
-            // Set the time shift for the sensor.
-            //SvtTimeShift sensorTimeShift = timeShifts.find(daqPair).get(0);
-            //sensor.setTimeShift(sensorTimeShift.getTimeShift());
+            // Set the t0 shift for the sensor.
+            SvtT0Shift sensorT0Shift = t0Shifts.find(daqPair).get(0);
+            sensor.setT0Shift(sensorT0Shift.getT0Shift());
         }
     }
 }

java/trunk/conditions/src/test/java/org/hps/conditions/svt
SvtDetectorSetupTest.java 1021 -> 1022
--- java/trunk/conditions/src/test/java/org/hps/conditions/svt/SvtDetectorSetupTest.java	2014-09-14 08:00:06 UTC (rev 1021)
+++ java/trunk/conditions/src/test/java/org/hps/conditions/svt/SvtDetectorSetupTest.java	2014-09-14 08:03:37 UTC (rev 1022)
@@ -17,7 +17,7 @@
  * @author Omar Moreno <[log in to unmask]>
  * @version $Id$
  */
-// TODO: Need to fix this tests so that it actually makes sense for the conditions we have.
+// TODO: Update this test with more meaningful test.
 public class SvtDetectorSetupTest extends TestCase {
 	
 	
@@ -58,6 +58,8 @@
         int totalSensors = 0; 
         for (HpsSiSensor sensor : sensors) {
 
+        	this.printDebug(sensor.toString());
+        	
         	totalSensors++; 
         	
         	// Check that hardware information seems reasonable.
@@ -66,20 +68,22 @@
 
             for (int channel = 0; channel < nChannels; channel++) {
         
-                // Check that conditions values are not zero:
-                /*assertTrue("Gain is zero.", sensor.getGain(channel) != 0);
-                assertTrue("Noise is zero.", sensor.getNoise(channel) != 0);
-                assertTrue("Pedestal is zero.", sensor.getPedestal(channel) != 0);
-                assertTrue("Time offset is zero.", sensor.getTimeOffset(channel) != 0);
-                assertTrue("PulseParameters points to null.", sensor.getPulseParameters(channel) != null);
-                double[] pulse = sensor.getPulseParameters(channel);
-                */
+            	//
+                // Check that channel conditions values are not zero
+            	//
+            	for(int sampleN = 0; sampleN < 6; sampleN++){
+            		assertTrue("Pedestal is zero.", sensor.getPedestal(channel, sampleN) != 0);
+            		assertTrue("Noise is zero.", sensor.getNoise(channel, sampleN) != 0);
+            	}
+                assertTrue("Gain is zero.", sensor.getGain(channel) != 0);
+                assertTrue("PulseParameters points to null.", sensor.getShapeFitParameters(channel) != null);
+                
             }
         }
         
         // Check for correct number of sensors processed.
 		this.printDebug("Total number of sensors found: " + totalSensors);
-		assertTrue(totalSensors == TOTAL_NUMBER_OF_SENSORS);
+		//assertTrue(totalSensors == TOTAL_NUMBER_OF_SENSORS);
         
         System.out.println("Successfully loaded conditions data onto " + totalSensors + " SVT sensors!"); 
     }
SVNspam 0.1