Commit in java/trunk/evio/src/main/java/org/hps/evio on MAIN
ECalEvioReader.java+32-681173 -> 1174
Revert changes to the ECAL EVIO reader made by celentan (his request)

java/trunk/evio/src/main/java/org/hps/evio
ECalEvioReader.java 1173 -> 1174
--- java/trunk/evio/src/main/java/org/hps/evio/ECalEvioReader.java	2014-10-11 17:33:20 UTC (rev 1173)
+++ java/trunk/evio/src/main/java/org/hps/evio/ECalEvioReader.java	2014-10-12 00:02:40 UTC (rev 1174)
@@ -34,13 +34,10 @@
 
     @Override
     public boolean makeHits(EvioEvent event, EventHeader lcsimEvent) {
-    	
-    	
         boolean foundHits = false;
         List<Object> hits = new ArrayList<Object>();
         hitClass = Object.class;
         int flags = 0;
-        int tag = 0;
         for (BaseStructure bank : event.getChildren()) {
             BaseStructureHeader header = bank.getHeader();
             int crateBankTag = header.getTag();
@@ -50,11 +47,9 @@
                     if (debug) {
                         System.out.println("ECal bank tag: " + header.getTag() + "; childCount: " + bank.getChildCount());
                     }
-                    try { 
+                    try {
                         for (BaseStructure slotBank : bank.getChildren()) {
-                            tag=slotBank.getHeader().getTag();
-                         
-                            if (tag == EventConstants.TRIGGER_BANK_TAG) {
+                            if (slotBank.getHeader().getTag() == EventConstants.TRIGGER_BANK_TAG) {
                                 if (debug) {
                                     int[] data = slotBank.getIntData();
                                     for (int i = 0; i < data.length; i++) {
@@ -63,42 +58,31 @@
                                 }
                                 continue;
                             }
-                            
-			    else if ((tag==EventConstants.ECAL_WINDOW_BANK_TAG)||(tag== EventConstants.ECAL_PULSE_BANK_TAG)||(tag==EventConstants.ECAL_PULSE_INTEGRAL_BANK_TAG)){
-                            
-                          
-                            
-                                for (CompositeData cdata : slotBank.getCompositeData()) {
-                                
-				    if (cdata==null){
-				      System.out.println("Cazzo.! "+slotBank.getHeader().getTag());
-				    }
-                                    if (slotBank.getHeader().getTag() != bankTag) {
-                                        bankTag = slotBank.getHeader().getTag();
-                                        System.out.printf("ECal format tag: 0x%x\n", bankTag);
-                                    }
-                                    switch (slotBank.getHeader().getTag()) {
-                                        case EventConstants.ECAL_WINDOW_BANK_TAG:
-                                            hits.addAll(makeWindowHits(cdata, crateBankTag));
-                                            hitClass = RawTrackerHit.class;
-                                            flags = 0;
-                                            break;
-                                        case EventConstants.ECAL_PULSE_BANK_TAG:
-                                            hits.addAll(makePulseHits(cdata, crateBankTag));
-                                            hitClass = RawTrackerHit.class;
-                                            flags = 0;
-                                            break;
-                                        case EventConstants.ECAL_PULSE_INTEGRAL_BANK_TAG:
-                                            hits.addAll(makeIntegralHits(cdata, crateBankTag));
-                                            hitClass = BaseRawCalorimeterHit.class;
-                                            flags = (1 << LCIOConstants.RCHBIT_TIME); //store timestamp
-                                            break;
-                                    
-				       }	
-                                    }
+                            for (CompositeData cdata : slotBank.getCompositeData()) {
+//                            CompositeData cdata = slotBank.getCompositeData();
+                                if (slotBank.getHeader().getTag() != bankTag) {
+                                    bankTag = slotBank.getHeader().getTag();
+                                    System.out.printf("ECal format tag: 0x%x\n", bankTag);
                                 }
-                            else{
-			      continue; //A.C. the TI case, for example, goes here.
+                                switch (slotBank.getHeader().getTag()) {
+                                    case EventConstants.ECAL_WINDOW_BANK_TAG:
+                                        hits.addAll(makeWindowHits(cdata, crateBankTag));
+                                        hitClass = RawTrackerHit.class;
+                                        flags = 0;
+                                        break;
+                                    case EventConstants.ECAL_PULSE_BANK_TAG:
+                                        hits.addAll(makePulseHits(cdata, crateBankTag));
+                                        hitClass = RawTrackerHit.class;
+                                        flags = 0;
+                                        break;
+                                    case EventConstants.ECAL_PULSE_INTEGRAL_BANK_TAG:
+                                        hits.addAll(makeIntegralHits(cdata, crateBankTag));
+                                        hitClass = BaseRawCalorimeterHit.class;
+                                        flags = (1 << LCIOConstants.RCHBIT_TIME); //store timestamp
+                                        break;
+                                    default:
+                                        throw new RuntimeException("Unsupported ECal format - bank tag " + slotBank.getHeader().getTag());
+                                }
                             }
                         }
                     } catch (EvioException e) {
@@ -134,32 +118,23 @@
             long timestamp = cdata.getLong();
             int nchannels = cdata.getNValue();
             if (debug) {
-                System.out.println("slot#=" + slot + "; trigger=" + trigger + "; timestamp=" + timestamp + "; nchannels=" + nchannels);System.out.flush();
+                System.out.println("slot#=" + slot + "; trigger=" + trigger + "; timestamp=" + timestamp + "; nchannels=" + nchannels);
             }
             for (int j = 0; j < nchannels; j++) {
                 short channel = cdata.getByte();
-               
-          
                 int nSamples = cdata.getNValue();
                 if (debug) {
-                    System.out.println("  channel=" + channel + "; nSamples=" + nSamples);System.out.flush();
+                    System.out.println("  channel=" + channel + "; nSamples=" + nSamples);
                 }
-                
-              
                 Long id = EcalConditions.daqToPhysicalID(crate, slot, channel);
-		
-		
+
                 short[] adcValues = new short[nSamples];
                 for (int i = 0; i < nSamples; i++) {
                     adcValues[i] = cdata.getShort();
                 }
                 if (id == null) {
                     System.out.printf("Crate %d, slot %d, channel %d not found in map\n", crate, slot, channel);
-                }
-                else if ((slot==20)&&(channel>=13)) { //A.C. temporary work around. Has to be here since we need to read the full EVIO composite.
-		  continue;
-		}
-                else {
+                } else {
                     hits.add(new BaseRawTrackerHit(0, id, adcValues, new ArrayList<SimTrackerHit>(), EcalConditions.getSubdetector().getDetectorElement().findDetectorElement(new Identifier(id)).get(0)));
                 }
             }
@@ -189,7 +164,6 @@
             }
             for (int j = 0; j < nchannels; j++) {
                 short channel = cdata.getByte();
-               
                 int npulses = cdata.getNValue();
                 if (debug) {
                     System.out.println("  channel=" + channel + "; npulses=" + npulses);
@@ -204,11 +178,7 @@
                     }
                     if (id == null) {
                         System.out.printf("Crate %d, slot %d, channel %d not found in map\n", crate, slot, channel);
-                    } 
-                    else if ((slot==20)&&(channel>=13)) { //A.C. temporary work around. Has to be here since we need to read the full EVIO composite.
-		      continue;
-		    }
-		    else {
+                    } else {
                         hits.add(new BaseRawTrackerHit(pulseNum, id, adcValues, new ArrayList<SimTrackerHit>(), EcalConditions.getSubdetector().getDetectorElement().findDetectorElement(new Identifier(id)).get(0)));
                     }
                 }
@@ -239,8 +209,6 @@
             }
             for (int j = 0; j < nchannels; j++) {
                 short channel = cdata.getByte();
-                //A.C. temporary work-around
-                if ((slot==20)&&(channel>=13)) continue;
                 int npulses = cdata.getNValue();
                 if (debug) {
                     System.out.println("  channel=" + channel + "; npulses=" + npulses);
@@ -255,11 +223,7 @@
                     }
                     if (id == null) {
                         System.out.printf("Crate %d, slot %d, channel %d not found in map\n", crate, slot, channel);
-                    } 
-                    else if ((slot==20)&&(channel>=13)) { //A.C. temporary work around. Has to be here since we need to read the full EVIO composite.
-		      continue;
-		    }
-                    else {
+                    } else {
                         hits.add(new BaseRawCalorimeterHit(id, pulseIntegral, pulseTime));
                     }
                 }
SVNspam 0.1