Print

Print


I don't think CalorimeterHit is the correct LCIO classes for modeling this.  BaseCalorimeterHit implements CalorimeterHit, which is a reconstruction class used when you have already converted ADC values from raw data to energy.  It isn't appropriate for modeling digits with discrete ADC values.

For integral mode, we use RawCalorimeterHit which has a single ADC amplitude, and for window mode the RawTrackerHit class is used.  Even though RawTrackerHit was originally designed for tracker data, it can be used generically to model any type of digit that has an array of ADC values with any size.  So perhaps RawTrackerHit can be used for the FADC mode.  Instead of 100 samples it could just have 2.  One could distinguish between the window and FADC modes by finding the number of ADC samples in this array (would be 2 or 100).

That's just one suggestion.  Otherwise, we can use a GenericObject collection to store whatever you want about the FADC data in an array of doubles or ints.

-----Original Message-----
From: Andrea Celentano [mailto:[log in to unmask]] 
Sent: Friday, December 05, 2014 7:00 AM
To: McCormick, Jeremy I.
Subject: BaseRawCalorimeterHit

Hi Jeremy,
currently, the ECAL evio -> lcio converter creates a collection of "BaseRawCalorimeterHit" objects when processing a pulse-mode evio file.
According to:

http://www.lcsim.org/sites/lcsim/apidocs/org/lcsim/event/base/BaseRawCalorimeterHit.html

these objects have only 3 "data" members: long id, int amplitude, int timestamp.

This is not sufficient for the new FADC mode we will have in the eng. 
run (mode 7), that adds 2 further info: the minimum and the maximum amplitude of the signal, in FADC units. Other modes (1,3) will not change.

Therefore, I ask you to add some fields to this class:

int minAmplitude;
int maxAmplitude;
int mode; --> to record which mode we used.

For mode 3, we can use minAmplitude=maxAmplitude=0.

I am not a java expert: in C++, I would derive a new class from BaseRawCalorimeterHit (like HPSRawCalorimeterHit) and use it. However, I do not know if other pieces of code, searching for a BaseRawCalorimeterHit, will work automatically, or if we need to change them.

Thanks

Andrea

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the HPS-SOFTWARE list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1