 |
 |
Tim, Matt, and Jeremy, Thanks for clarifications. Yes, from one side it is fills good not to write a code and not worry about cleaning it, but from other hand it s hard to appreciate how much efforts is going into making the code easy to maintain. Stepan On 1/5/15 11:07 PM, Nelson, Timothy Knight wrote: > Hi Stepan, > > It means that the class hierarchies for ECal clustering algorithms and ECal cluster objects has been a somewhat cobbled together mess, which gets messier and more difficult to modify and upgrade with every ensuing, ad-hoc iteration if it isn't improved. It's better to make these structural changes now than later when the code is an even bigger mess and not interrupting analysis is even more critical. So, this is not about current function (which is unaffected by the changes), but about the (object-oriented) structure that makes the code easier to maintain and improve going forward. > > In short: nothing to worry about unless you are writing code! > > Cheers, > Tim > >> On Jan 5, 2015, at 7:37 PM, Stepan Stepanyan <[log in to unmask]> wrote: >> >> Matt, >> >> Thanks for the reply, I new that pass0 used IC clustering too, but Jeremy's >> last email kind of confused me. What it means "I'm hoping eventually we >> can completely remove from the code the HPSEcalCluster and HPSEcalClusterIC >> classes" ... >> >> Stepan >> On 1/5/15 9:37 PM, Graham, Mathew Thomas wrote: >>> On Jan 5, 2015, at 5:37 PM, Stepan Stepanyan <[log in to unmask]> wrote: >>> >>>> Jeremy, >>>> >>>> Can you or someone explain in plane english what is going on with ECal clustering algorithm. >>>> We have the code ready for half a year now, checked with simulations and documented as a >>>> HPS-NOTE. Now that we have data we seems cannot use that algorithm for some technical >>>> reasons, or I am wrong. >>> As I mentioned in my earlier email announcing “pass 0”, the recon files do have IC clusters included. The algorithm is completely usable and has been and is being used. >>> ######################################################################## >>> Use REPLY-ALL to reply to list >>> >>> To unsubscribe from the HPS-SOFTWARE list, click the following link: >>> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1 >> ######################################################################## >> Use REPLY-ALL to reply to list >> >> To unsubscribe from the HPS-SOFTWARE list, click the following link: >> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1 > ######################################################################## > Use REPLY-ALL to reply to list > > To unsubscribe from the HPS-SOFTWARE list, click the following link: > https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1 ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the HPS-SOFTWARE list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1