 |
 |
Okay.... But the problem here is that any downstream analysis Driver in a separate job which tries to retrieve event information using this (public) class will fail. Therefore, I believe it should be removed, in favor of using the base class from LCSim. And as far as I can tell there is only one reference in our entire code base that uses the window size information, which is just an analysis plot. So can the class simply be removed? I assume you have some other way of getting the window size or that it is simply a hard-coded parameter. (Not sure, maybe you can clarify for me where this information comes from in the first place.) --Jeremy -----Original Message----- From: Sho Uemura [mailto:[log in to unmask]] Sent: Friday, January 09, 2015 12:05 PM To: McCormick, Jeremy I. Cc: hps-software Subject: Re: HPSRawCalorimeterHit The window size there is only used for MC studies, and it doesn't need to be persisted. On Fri, 9 Jan 2015, McCormick, Jeremy I. wrote: > Hi, Sho. > > In the ECAL code, is there another way we could keep track of the window size rather than extending an LCIO class? > > e.g. > > ecal-recon/src/main/java/org/hps/recon/ecal/HPSRawCalorimeterHit.java > > If this is something that is the same for all hits in the collection, then it would be possible to use a setting on the collection itself rather than each hit. > > Or is this value specific to each hit? > > As far as I can tell, the added method getWindowSize() is not even used anyplace in the reconstruction, so can it simply be removed? > > --Jeremy > > ###################################################################### > ## > Use REPLY-ALL to reply to list > > To unsubscribe from the HPS-SOFTWARE list, click the following link: > https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1 > ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the HPS-SOFTWARE list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1