Hi, Although HPSEcalClusterIC was inherting this calculation from HPSEcalCluster, it did not use these position calculations. The position calculations were done within the clustering code (used a setPosition method which is now in BaseCluster). As I am moving them out of the clustering code to a separate calculator, this calculation as written is not currently being used/analyzed in offline reconstruction. -Holly On Tue, Jan 13, 2015 at 2:34 PM, McCormick, Jeremy I. < [log in to unmask]> wrote: > Hi, > > In looking over the clustering code, I noticed that in HPSEcalCluster a > position property calculation is automatically performed, using some code > that was copied from the tensor property calculator in LCSim. So this > calculation used to be done automatically for most of the clustering > algorithms, as they used either HPSEcalEcluster or HPSEcalClusterIC which > extends that class. For the “IC” clusters, this is further supplemented by > PID based recalculation of the position and energy within HPSEcalClusterIC. > > I am wondering, does this really make sense to apply the tensor property > calculation to all the different types of clusters? Is this supposed to be > providing some kind of reasonable default? What was the idea here? > > For instance, should this property calculation really be applied to CTP > and GTP clusters, which are more of a concept based on the DAQ/trigger > rather than physics? Should the position of the cluster there be only > based on the seed hit? > > In the new clustering “framework” it is possible to easily apply these > corrections via ClusterDriver to whatever cluster collection you are > processing, as I have extracted them into a ClusterPropertyCalculator. > > I am basically wondering when this does and doesn’t make sense to do by > default, and what people doing analysis are expecting here. > > Thanks. > > —Jeremy > ######################################################################## > Use REPLY-ALL to reply to list > > To unsubscribe from the HPS-SOFTWARE list, click the following link: > https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1 > > > -- > BEGIN-ANTISPAM-VOTING-LINKS > ------------------------------------------------------ > > NOTE: This message was trained as non-spam. If this is wrong, > please correct the training as soon as possible. > > > Teach CanIt if this mail (ID 03NDvzinh) is spam: > > Spam: > https://www.spamtrap.odu.edu/canit/b.php?i=03NDvzinh&m=9f3669cca449&t=20150113&c=s > > Not spam: > https://www.spamtrap.odu.edu/canit/b.php?i=03NDvzinh&m=9f3669cca449&t=20150113&c=n > > Forget vote: > https://www.spamtrap.odu.edu/canit/b.php?i=03NDvzinh&m=9f3669cca449&t=20150113&c=f > ------------------------------------------------------ > END-ANTISPAM-VOTING-LINKS > > ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the HPS-SOFTWARE list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1