 |
 |
Fabrice, Let's do the 2014_12 release without DM-627, and we will discuss how to proceed with logging on Wednesday at the hangout. I wasn't aware that we were planning to move towards yaml-based configuration (did I miss something?). If indeed that is our plan, I agree there is no point in undoing what you did, and re-implementing it back soon. Jacek On 01/05/2015 10:43 PM, Fabrice Jammes wrote: > Hi Jacek, > > Le 05/01/2015 18:41, Jacek Becla a écrit : >> Fabrice, >> >> I thought about it a bit more... >> >> I think it would be better to not add new dependencies >> that we never discussed/approved, even if it means a few >> days of cleanup of what was done in DM-627. >> >> Would it be possible to massage DM-627 so that it does not >> touch any logging code, release it, and implement logging >> based on our log module, without yaml, under a separate >> ticket? > I need at least 1 day to do this and revert to the previous log system. > If we want to remove all python-yaml dependencies I also need to > use Andy configuration parser and remove description.yaml for > each test case and re-test everything, I need 1 or 2 days more here. > > So this is between 1 and 3 days for something which should be anyway > re-implemented soon. So I'm not very enthusiastic for doing this, are you > sure you really want it? >> >> >> Does the tip of the master work / does it pass integration >> tests *without* DM-627? > Yes it does. >> Even if it does not, I think I'd >> be tempted to just assume the Dec release is broken and >> cut a properly working release once DM-627 is fixed, >> sometime later in January. >> >> Sorry we are making you undo the work you have done over >> the break! > I feel quite frustrated with it because I really think this job is good: > I put lots of effort to have a nicer, cleaner and shorter code for > integration tests. > They are much more performant (from 160 sec to 70 sec), and a minor but > hard to find > Qserv bug has been solved. So I think the goal of the ticket has been > achieved. > > Of course, I'm ok to solve this minor problems (log and pyyaml) in > future tickets, after > we've defined a strong design together. > > Cheers > > Fabrice >> >> Jacek >> >> ######################################################################## >> Use REPLY-ALL to reply to list >> >> To unsubscribe from the QSERV-L list, click the following link: >> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=QSERV-L&A=1 > ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the QSERV-L list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=QSERV-L&A=1