Why don’t we add this as fields to the EcalChannel condition as position_x and position_y?

I can’t work on this right now but we could do it next week.

Or we could tweak the geometry description but I think it would be hard to get them in exactly the right place.

(CC’ing software list for more input from others.)

On Feb 12, 2015, at 12:00 PM, Kyle McCarty <[log in to unmask]> wrote:

Hello Jeremy,

I got a mapping chart for ix/iy to x/y from Ben that matches what the hardware uses. I am going to implement this instead, because it will be more accurate. Do you have a preference on how this chart is coded into the software (i.e. external file that is part of the build, hardcoded into a class, etc.) and where (TriggerModule, some utility class)?

Thanks,

Kyle

On Wed, Feb 11, 2015 at 11:25 PM, McCormick, Jeremy I. <[log in to unmask]> wrote:

Not sure.  I will look into it tomorrow.

On Feb 11, 2015, at 7:47 PM, Kyle McCarty <[log in to unmask]> wrote:

Hello Jeremy,

I still get the same error as before after an "svn up" to the most recent version. The error message is:

java.lang.NullPointerException
        at org.lcsim.event.base.BaseHit.getIDDecoder(BaseHit.java:125)
        at org.lcsim.event.base.BaseHit.getSubdetector(BaseHit.java:54)
        at org.lcsim.event.base.BaseHit.getIdentifierHelper(BaseHit.java:109)
        at org.lcsim.event.base.BaseHit.getIdentifierFieldValue(BaseHit.java:157)
        at org.hps.users.kmccarty.TriggerDiagnosticDriver.detectorChanged(TriggerDiagnosticDriver.java:57)
        at org.lcsim.util.Driver.detectorChanged(Driver.java:169)
        at org.lcsim.util.DriverAdapter.detectorChanged(DriverAdapter.java:86)
        at org.lcsim.util.DriverAdapter.recordSupplied(DriverAdapter.java:72)
        at org.freehep.record.loop.DefaultRecordLoop.consumeRecord(DefaultRecordLoop.java:832)
        at org.freehep.record.loop.DefaultRecordLoop.loop(DefaultRecordLoop.java:668)
        at org.freehep.record.loop.DefaultRecordLoop.execute(DefaultRecordLoop.java:566)
        at org.lcsim.util.loop.LCSimLoop.loop(LCSimLoop.java:153)
        at org.lcsim.job.JobControlManager.run(JobControlManager.java:427)
        at org.hps.job.JobManager.run(JobManager.java:36)
        at org.lcsim.job.JobControlManager.run(JobControlManager.java:185)
        at org.hps.job.JobManager.main(JobManager.java:18)

This occurs when running the code:

    @Override
    public void detectorChanged(Detector detector) {
        for(EcalCrystal crystal : detector.getSubdetector("Ecal").getDetectorElement().findDescendants(EcalCrystal.class)) {
            System.out.println(crystal.getIdentifier().getValue());
            CalorimeterHit tempHit = CalorimeterHitUtilities.create(1.000, 10.0, crystal.getIdentifier().getValue());
           
            int ix = tempHit.getIdentifierFieldValue("ix");
            int iy = tempHit.getIdentifierFieldValue("iy");
            double[] xyz = tempHit.getPosition();
           
            System.out.printf("(%3d, %3d) --> (%.2f, %.2f)%n", ix, iy, xyz[0], xyz[1]);
        }
    }

This fails at the "int ix" line. Any idea what is causing it?

Thanks,

Kyle

On Wed, Feb 11, 2015 at 6:37 PM, Kyle McCarty <[log in to unmask]> wrote:

I'm away from the computer at the moment, but I will try it again tonight and let you know. I hadn't realized that you had already looked at it.

Thanks,

Kyle

On Feb 11, 2015 6:32 PM, "McCormick, Jeremy I." <[log in to unmask]> wrote:

I think I fixed this with some tweaks to lcsim.  Do you mind testing the same code again?  I believe it should work but let me know either way....

-----Original Message-----
From: Kyle McCarty [mailto:[log in to unmask]]
Sent: Wednesday, February 11, 2015 3:31 PM
To: McCormick, Jeremy I.
Subject: RE: HPS Release Time

You said you'd look into the error I got from trying what you suggested on Monday. Did I miss the response?

On Feb 11, 2015 4:39 PM, "McCormick, Jeremy I." <[log in to unmask]> wrote:


        Hi, Kyle.

        > Have you had a chance to look into that issue with the position from x/y index?

        Isn't this fixed?  Try it again please and let me know...

        --Jeremy

        -----Original Message-----
        From: Kyle McCarty [mailto:[log in to unmask]]
        Sent: Wednesday, February 11, 2015 1:33 PM
        To: McCormick, Jeremy I.
        Subject: Re: HPS Release Time

        Hello Jeremy,

        Have you had a chance to look into that issue with the position from x/y index? It would be good to have that so I can include the complete TriggerModule class in this release.

        Thanks,

        Kyle

        On Feb 11, 2015 3:49 PM, "McCormick, Jeremy I." <[log in to unmask]> wrote:


                Hi,

                It is about that time again.  We would like to make a release of HPS Java 3.1 tomorrow afternoon from the current 3.1-SNAPSHOT dev version being used in trunk.

                This has been a good snapshot (maybe the best ever?!) but it is time to immortalize the huge stack of JIRA items that have been resolved against it.

                This release will be used for the upcoming reconstruction pass 1, which we plan to start Friday, so if there are any changes that need to be in there , they should be put into SVN trunk (and tested!) within ~24 hours.

                Please let me know if you have any questions or comments about this.

                Thanks.

                --Jeremy

                ########################################################################
                Use REPLY-ALL to reply to list

                To unsubscribe from the HPS-SOFTWARE list, click the following link:
                https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1