Print

Print


I see what you mean.  I reverted the commits that changed the detector and run number for now, so old behavior should be restored.

Can you send me all the full commands you are having trouble with so I can test them on the dev db?

I don’t know why the behavior of “-m” would have changed.  I haven’t touched that code in awhile.

Thanks.

On Mar 7, 2015, at 7:21 AM, Nathan Baltzell <[log in to unmask]> wrote:

> Hi Jeremy,
> 
> Isn't the result of this code independent of the detector?  If so, we should not need
> to define a detector at all just to modify or read the database.  I can't find anywhere
> in the database that knows about this "detector name".
> 
> Similarly, the "load" command, which only uploads constants to the database and
> doesn't link them with run number, shouldn't need a run number.
> 
> 
> And there's more new behavioral changes:
> 
> The add command now requires the -r come after the "add" and not before.  Throws
> null pointer exception in AddCommand otherwise.  And if you don't specify it before
> the "add" also, throws null pointer exception in commandLineTool.setupConditionsManager.
> 
> java … -r 4000 add -r 4000 ….
> 
> Do these run number need to be the same?  Do both of their values affect the result?
> 
> 
> And now my comments with the -m switch are getting truncated to only the first word.
> 
> -Nathan
> 
> 
> 
> 
> 
> On Mar 5, 2015, at 11:44 PM, "McCormick, Jeremy I." <[log in to unmask]> wrote:
> 
>> Hi,
>> 
>> I made some changes just now which may affect how you have been using some of the command line tools in HPS Java.
>> 
>> The detector name argument was made a requirement when using the EvioToLcio and conditions CommandLineTool classes.
>> 
>> This was done because, given the large number of detector models that we have available, there is really no reasonable default that should be used for a detector name.  It must always be explicitly provided now.
>> 
>> These programs will now throw a RuntimeException if you do not supply the detector name using the "-d" argument.
>> 
>> Additionally, when using the conditions command line tool, you must use the "-r" argument to supply a run number, because, again, there is not really any default that should be used for this.
>> 
>> I think it makes sense to do this in order to avoid any ambiguity and unwanted default behavior.
>> 
>> If you have any questions about this then please let me know.
>> 
>> --Jeremy
> 

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the HPS-SOFTWARE list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1