Print

Print


I am, thank you.  I’m still anti-changing anything that’s not broken right now.  


> On May 4, 2015, at 3:45 PM, McCormick, Jeremy I. <[log in to unmask]> wrote:
> 
> This isn't used directly in scripts as far as I can tell.  It is an abstract class.  Maybe you're thinking of the EvioToLcio class?
> 
> -----Original Message-----
> From: Graham, Mathew Thomas 
> Sent: Monday, May 04, 2015 3:44 PM
> To: McCormick, Jeremy I.
> Cc: Omar Moreno; Uemura, Sho; hps-software
> Subject: Re: change class name
> 
> it’s hardcoded in everyone’s scripts.  
> 
> 
>> On May 4, 2015, at 3:43 PM, McCormick, Jeremy I. <[log in to unmask]> wrote:
>> 
>> I don't see this being very disruptive as it is a simple name change refactoring without much potential for breaking anything, but I can leave it if you want....
>> 
>> -----Original Message-----
>> From: [log in to unmask] [mailto:[log in to unmask]] On Behalf Of Omar Moreno
>> Sent: Monday, May 04, 2015 3:42 PM
>> To: McCormick, Jeremy I.
>> Cc: Uemura, Sho; Omar Moreno; hps-software
>> Subject: Re: change class name
>> 
>> Is this really something that is necessary to do now?
>> 
>> On Mon, May 4, 2015 at 3:35 PM, McCormick, Jeremy I. <[log in to unmask]> wrote:
>> 
>> 
>> 	Hi,
>> 	
>> 	Can I change this class name?
>> 	
>> 	evio/src/main/java/org/hps/evio/EvioReader.java
>> 	
>> 	It conflicts annoyingly and confusingly with a primary class from the EVIO package.
>> 	
>> 	I was thinking of changing it to "HitMaker" or if you have any suggestions let me know.
>> 	
>> 	But I don't think it should have the same name as the primary reader class from EVIO, and it isn't really an EvioReader anyways.
>> 	
>> 	Impact on the code should be minimal.  Let me know if there's any big objections.
>> 	
>> 	--Jeremy
>> 	
>> 
>> 
>> 
>> ########################################################################
>> Use REPLY-ALL to reply to list
>> 
>> To unsubscribe from the HPS-SOFTWARE list, click the following link:
>> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1
> 


########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the HPS-SOFTWARE list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1