 |
 |
Okay. I just wanted to make clear that this is not coming from my code and I will not fix it. On Tue, 2 Jun 2015, McCormick, Jeremy I. wrote: > I'm aware of it. When some types of conditions such as DAQ or channel mappings are missing this should always be a fatal error, so that's working as intended for those conditions. There are other conditions that could be made optional such as timing offsets, etc. We would just need to include additional code in that class to properly handle this and provide defaults. You're right that the class as written does not handle this right now. You can feel free to change this class if you want to allow certain conditions to not be present for a job. > > On the other hand, most of the time when any type of conditions are missing that are needed to properly configure the detector for the run, throwing an error is not unreasonable behavior. > >> On Jun 2, 2015, at 3:37 PM, Sho Uemura <[log in to unmask]> wrote: >> >> SvtDetectorSetup (which is called from ConditionsDriver) crashes if it can't find a conditions set it needs. >> >>> On Tue, 2 Jun 2015, McCormick, Jeremy I. wrote: >>> >>> There are SVT timing constants in the db for run 0 now, so try this again. The offset and phase are both set to 0 and collection ID should be 1030. >>> >>> The job shouldn't automatically fail if some condition key is missing, only when a Driver or other code tries to access conditions without them being present in the records loaded for the current run. You can either wrap the getCachedConditions() call in a try block to trap for non-existent conditions (not the preferred way). Or a better way is to use the method DatabaseConditionsManager.hasConditionsRecord(name) to check before you try to fetch them. >>> >>> On Jun 2, 2015, at 10:20 AM, Sho Uemura <[log in to unmask]<mailto:[log in to unmask]>> wrote: >>> >>> I think the conditions code crashes with "No conditions were found with key" if any condition is undefined for the current run. So there is no nice way for conditions users (meaning, me) to guard against conditions not being defined; that ball is in your court. >>> >>> A default of phase=0, offset=0 should be fine. >>> >>> >>> ######################################################################## >>> Use REPLY-ALL to reply to list >>> >>> To unsubscribe from the HPS-SOFTWARE list, click the following link: >>> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1 >>> > > ######################################################################## > Use REPLY-ALL to reply to list > > To unsubscribe from the HPS-SOFTWARE list, click the following link: > https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1 > ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the HPS-SOFTWARE list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1