Alright, I'll go ahead and fix the bug. On Jul 7, 2015 8:53 PM, "Maruyama, Takashi" <[log in to unmask]> wrote: > Hi Omar, > > I have checked the trigger bits are written correctly to the DST. So > Nathan is right; the DST is correct, but if HpsEvent C++ API is used to > read/analyze the DST, HpsEvent.h needs to be fixed. > > Takashi > ________________________________________ > From: Omar Moreno [[log in to unmask]] > Sent: Tuesday, July 7, 2015 6:49 PM > To: Nathan Baltzell > Cc: hps-software; Maruyama, Takashi > Subject: Re: Trigger bits problem in pass1 D > > Hi Takashi, Nathan, > > I'll check if the trigger bits are being written correctly to the DST. If > so, then the problem is just with reading them so we wouldn't need to rerun > the DST maker on pass1 data. > > --Omar Moreno > > On Jul 7, 2015 5:20 PM, "Nathan Baltzell" <[log in to unmask]<mailto: > [log in to unmask]>> wrote: > So this is not a problem with the pass1 DSTs, but > a problem in the code used to read them? > > -Nathan > > > > > On Jul 7, 2015, at 2:18 PM, "Maruyama, Takashi" <[log in to unmask] > <mailto:[log in to unmask]>> wrote: > > > Thank you, Nathan. There is a typo in HpsEvent.h. > > > > bool isSingle1Trigger() const { return (bool) single0_trigger; } ; > > > > "single0_trigger" should be "single1_trigger". > > > > Takashi > > > > -----Original Message----- > > From: Nathan Baltzell [mailto:[log in to unmask]<mailto:[log in to unmask] > >] > > Sent: Tuesday, July 07, 2015 10:27 AM > > To: Maruyama, Takashi > > Cc: hps-software > > Subject: Re: Trigger bits problem in pass1 DST > > > > Hi Takashi, > > > > I'm not seeing the same by just counting events with no trigger bits set > according to the DST variables. For example, this returns zero for the > file you mentioned and a few others I tried: > > > > > HPS_Event->GetEntries("pair1_trigger+pair0_trigger+pulser_trigger+single0_trigger+single1_trigger > == 0") > > > > -Nathan > > > > > > On Jul 7, 2015, at 13:06, Maruyama, Takashi <[log in to unmask] > <mailto:[log in to unmask]>> wrote: > > > >> There is a minor problem in trigger bits in pass1 DST. There are about > 7% of events with no trigger bits set. There are about 2% of events with > both Single0 and Single1. Kyle dumped first 1000 EVIO events in Run 5797 > File 0, and I compared with the DST. Here is a work around. > >> > >> 1) If both Single0 and Single1 are set, it is Single0. > >> 2) If no trigger bits are set, it is Single1. > >> > >> Everything else is correct. > >> > >> Takashi > >> > >> ###################################################################### > >> ## > >> Use REPLY-ALL to reply to list > >> > >> To unsubscribe from the HPS-SOFTWARE list, click the following link: > >> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1 > > > > ######################################################################## > > Use REPLY-ALL to reply to list > > > > To unsubscribe from the HPS-SOFTWARE list, click the following link: > > https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1 > > ######################################################################## > Use REPLY-ALL to reply to list > > To unsubscribe from the HPS-SOFTWARE list, click the following link: > https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1 > > ######################################################################## > Use REPLY-ALL to reply to list > > To unsubscribe from the HPS-SOFTWARE list, click the following link: > https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1 > ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the HPS-SOFTWARE list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=HPS-SOFTWARE&A=1