Print

Print


This is really unfortunate -- it abrogates a big part of the value of 
teasing PRs apart into multiple commits.  I suppose you could have two 
windows open, and review by commit, then fish in the other window and 
comment on the flat files changed?  Sheesh, github...

On 08/24/2015 05:16 PM, Becla, Jacek wrote:
> In case you missed it (K-T mentioned it during one of the sessions), ticket reviews in github should be done on “files changed”, not on individual commits, because after rebasing comments done on individual commits are harder to find.
>
> J.
>
> ########################################################################
> Use REPLY-ALL to reply to list
>
> To unsubscribe from the QSERV-L list, click the following link:
> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=QSERV-L&A=1

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the QSERV-L list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=QSERV-L&A=1