Print

Print


Throwing exceptions in a destructor causes warnings with gcc 6, and since -Werror is used this becomes an error:

XrdSys/XrdSysPthread.hh: In destructor 'XrdSysSemaphore::~XrdSysSemaphore()':
XrdSys/XrdSysPthread.hh:356:31: error: throw will always call terminate() [-Werror=terminate]
XrdSys/XrdSysPthread.hh:356:31: note: in C++11 destructors default to noexcept

There are two destructors in the code that does this. This pull request comments out these lines of code.

You can view, comment on, or merge this pull request online at:

  https://github.com/xrootd/xrootd/pull/334

-- Commit Summary --

  * Don't throw exceptions in destructors

-- File Changes --

    M src/XrdSys/XrdSysPthread.hh (18)
    M src/XrdSys/XrdSysXSLock.cc (2)

-- Patch Links --

https://github.com/xrootd/xrootd/pull/334.patch
https://github.com/xrootd/xrootd/pull/334.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/334

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1