We recently enabled GSI authentication with xrootd 4.2.3. It appears each GSI authentication causes about 6kB of memory to be leaked.

Toward the beginning of XrdSecProtocolgsi::Authenticate(), memory may be
allocated for the Entity with strdup():
https://github.com/xrootd/xrootd/blob/a76eccc1f2/src/XrdSecgsi/XrdSecProtocolgsi.cc#L1873

Later in the same function, the Entity may be replaced with an entry from the
cache:
https://github.com/xrootd/xrootd/blob/a76eccc1f2/src/XrdSecgsi/XrdSecProtocolgsi.cc#L1951

However, the memory allocated with strdup() is not free()d. This patch calls FreeEntity()
before replacing Entity with a copy from the cache.

Regards,
John

valgrind output for the largest lost block after 20 GSI authentications (xrootd 4.2.3):

==10420== 120,760 bytes in 20 blocks are definitely lost in loss record 2,541 of 2,543
==10420==    at 0x4A06A2E: malloc (vg_replace_malloc.c:270)
==10420==    by 0x324EE80EC1: strdup (in /lib64/libc-2.12.so)
==10420==    by 0x66E717F: XrdSecProtocolgsi::Authenticate(XrdSecBuffer*, XrdSecBuffer**, XrdOucErrInfo*) (XrdSecProtocolgsi.cc:1873)
==10420==    by 0x4C67959: XrdXrootdProtocol::do_Auth() (XrdXrootdXeq.cc:155)
==10420==    by 0x4F37148: XrdLink::DoIt() (XrdLink.cc:397)
==10420==    by 0x4F3A624: XrdScheduler::Run() (XrdScheduler.cc:333)
==10420==    by 0x4F3A818: XrdStartWorking(void*) (XrdScheduler.cc:85)
==10420==    by 0x4EFF3AE: XrdSysThread_Xeq (XrdSysPthread.cc:86)
==10420==    by 0x324F607AA0: start_thread (in /lib64/libpthread-2.12.so)
==10420==    by 0x324EEE893C: clone (in /lib64/libc-2.12.so)

You can view, comment on, or merge this pull request online at:

  https://github.com/xrootd/xrootd/pull/347

Commit Summary

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub


Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1