Print

Print


  Branch: refs/heads/master
  Home:   https://github.com/xrootd/xrootd
  Commit: 9fd461637f1037c833ba4ee653dda8f1b47b947e
      https://github.com/xrootd/xrootd/commit/9fd461637f1037c833ba4ee653dda8f1b47b947e
  Author: John Thiltges <[log in to unmask]>
  Date:   2016-03-21 (Mon, 21 Mar 2016)

  Changed paths:
    M src/XrdSecgsi/XrdSecProtocolgsi.cc

  Log Message:
  -----------
  Free Entity before replacing it from the cache

Toward the beginning of XrdSecProtocolgsi::Authenticate(), memory may be
allocated for the Entity with strdup():
https://github.com/xrootd/xrootd/blob/a76eccc1f2/src/XrdSecgsi/XrdSecProtocolgsi.cc#L1873

Later in the same function, the Entity may be replaced with an entry from the
cache:
https://github.com/xrootd/xrootd/blob/a76eccc1f2/src/XrdSecgsi/XrdSecProtocolgsi.cc#L1951

However, the memory allocated with strdup() is not free()d. Call FreeEntity()
before replacing Entity with a copy.


  Commit: b711436bb3a39d1db38c047c6c86518617b43a33
      https://github.com/xrootd/xrootd/commit/b711436bb3a39d1db38c047c6c86518617b43a33
  Author: gganis <[log in to unmask]>
  Date:   2016-03-23 (Wed, 23 Mar 2016)

  Changed paths:
    M src/XrdSecgsi/XrdSecProtocolgsi.cc

  Log Message:
  -----------
  Merge pull request #347 from jthiltges/gsi-auth-strdup

With GSI auth, free Entity variable before replacing it from the cache


Compare: https://github.com/xrootd/xrootd/compare/422ae9cc6ca0...b711436bb3a3

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1