bbockelm commented on this pull request.
> @@ -507,8 +507,8 @@ const char *XrdCryptosslX509::IssuerHash(int alg)
if (issueroldhash.length() <= 0) {
// Make sure we have a certificate
if (cert) {
- char chash[15] = {0};
- snprintf(chash,15,"%08lx.0",X509_NAME_hash_old(cert->cert_info->issuer));
+ char chash[30] = {0};
+ snprintf(chash, sizeof(chash), "%08lx.0", X509_NAME_hash_old(cert->cert_info->issuer));
Yup, that's the correct format. I believe it's to allow for collisions (so you can have a CA with `.0`, `.1`, `.2`, ....
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/448
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
