davidlt commented on this pull request.
> @@ -243,7 +243,7 @@ class ZipArchiveReaderImpl
{
delete pBuffer;
ClearRecords();
- pArchive.Close();
+ XRootDStatus st = pArchive.Close();
Looks like to void this official way would be to add a cast to void, i.e., ` (void) pArchive.Close();` but GCC currently doesn't detect that (bug #66425), Clang does. According to C++17 standard we have `nodiscard` which is unused-result and it says that compile should only warn/error if cast to void is missing.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/448
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
