Print

---

You missed the following:

src/XrdClient/XrdClient.cc: In member function 'virtual bool XrdClient::OpenFileWhenRedirected(char*, bool&)':
src/XrdClient/XrdClient.cc:1375:14: error: enum constant in boolean context [-Werror=int-in-bool-context]
  options &= !kXR_delete;
              ^~~~~~~~~~
src/XrdClient/XrdClient.cc:1383:14: error: enum constant in boolean context [-Werror=int-in-bool-context]
  options &= !kXR_new;
              ^~~~~~~

You are using boolean operation where you needed a bitwise operation.

src/XrdCl/XrdClZipArchiveReader.cc: In destructor 'XrdCl::ZipArchiveReaderImpl::~ZipArchiveReaderImpl()':
src/XrdCl/XrdClZipArchiveReader.cc:246:23: error: ignoring return value of 'XrdCl::XRootDStatus XrdCl::File::Close(uint16_t)', declared with attribute warn_unused_result [-Werror=unused-result]
       pArchive.Close();
                       ^
In file included from src/XrdCl/XrdClZipArchiveReader.cc:27:0:
src/XrdCl/XrdClFile.hh:121:20: note: declared here
       XRootDStatus Close( uint16_t timeout = 0 ) XRD_WARN_UNUSED_RESULT;
                    ^~~~~

I am not fully sure how to properly handle this inside ~ZipArchiveReaderImpl(). I know, that only saving return value (but not using it) already removed the error, but is not a right solution probably. Maybe dtor should be marked as noexcept(false) and should throw an exception/terminate.

Will check further. Now it compiles up to 71%.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1