Actually, the fix we will be using is to issue an error message is the <br>
status is not clean. That will be posted tomorrow.<br>
<br>
Andy<br>
<br>
On Mon, 16 Jan 2017, Brian Bockelman wrote:<br>
<br>
&gt; bbockelm commented on this pull request.<br>
&gt;<br>
&gt;<br>
&gt;<br>
&gt;&gt; @@ -243,7 +243,7 @@ class ZipArchiveReaderImpl<br>
&gt;     {<br>
&gt;       delete pBuffer;<br>
&gt;       ClearRecords();<br>
&gt; -      pArchive.Close();<br>
&gt; +      XRootDStatus st = pArchive.Close();<br>
&gt;<br>
&gt; There is an attribute for this situation added in C++17; is there a pre-existing `gnu:` attribute that we could use?<br>
&gt;<br>
&gt; -- <br>
&gt; You are receiving this because you commented.<br>
&gt; Reply to this email directly or view it on GitHub:<br>
&gt; https://github.com/xrootd/xrootd/pull/448<br>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/xrootd/xrootd/pull/448#issuecomment-272922750">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AD7YjnCXBl4oeaTbtGS4Tr6vQ7MIFfjqks5rS6p1gaJpZM4Li0Tn">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AD7YjhZOONDGRvG4A5QgjcGT-AIqvaSbks5rS6p1gaJpZM4Li0Tn.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/xrootd/xrootd/pull/448#issuecomment-272922750"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<!cript type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/xrootd/xrootd","title":"xrootd/xrootd","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/xrootd/xrootd"}},"updates":{"snippets":[{"icon":"PERSON","message":"@abh3 in #448: Actually, the fix we will be using is to issue an error message is the \nstatus is not clean. That will be posted tomorrow.\n\nAndy\n\nOn Mon, 16 Jan 2017, Brian Bockelman wrote:\n\n\u003e bbockelm commented on this pull request.\n\u003e\n\u003e\n\u003e\n\u003e\u003e @@ -243,7 +243,7 @@ class ZipArchiveReaderImpl\n\u003e     {\n\u003e       delete pBuffer;\n\u003e       ClearRecords();\n\u003e -      pArchive.Close();\n\u003e +      XRootDStatus st = pArchive.Close();\n\u003e\n\u003e There is an attribute for this situation added in C++17; is there a pre-existing `gnu:` attribute that we could use?\n\u003e\n\u003e -- \n\u003e You are receiving this because you commented.\n\u003e Reply to this email directly or view it on GitHub:\n\u003e https://github.com/xrootd/xrootd/pull/448\n"}],"action":{"name":"View Pull Request","url":"https://github.com/xrootd/xrootd/pull/448#issuecomment-272922750"}}}</script><br>
<hr>
<p align="left">
Use REPLY-ALL to reply to list</p>
<p align="center">To unsubscribe from the XROOTD-DEV list, click the following link:<br>
<a href="https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1" target="_blank">https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1</a>
</p>